Page MenuHomePhabricator

Add a data formatter for libc++ std::bitset

Authored by labath on Nov 13 2017, 10:27 AM.

Diff Detail


Event Timeline

labath created this revision.Nov 13 2017, 10:27 AM
jingham accepted this revision.Nov 13 2017, 12:21 PM

Looks fine. Seems like Update doesn't need to grab the bool type on every pass, but I don't think that matters IRL. Thanks for adding this.

62 ↗(On Diff #122685)

Does this need to be done every time you Update? Couldn't you do this in the constructor instead? This is probably pretty cheap call, so it doesn't matter much, but it seems odd.

This revision is now accepted and ready to land.Nov 13 2017, 12:21 PM
labath marked an inline comment as done.Nov 14 2017, 3:13 AM
labath added inline comments.
62 ↗(On Diff #122685)

The other pretty printers were doing all of their initialization in the Update function, but I don't see a reason why this couldn't be done in the constructor. In that case, I can probably do the byte order and pointer size computation there as well.

This revision was automatically updated to reflect the committed changes.
labath marked an inline comment as done.