Page MenuHomePhabricator

Itanium ABI: Update getAddrOfVTable to set the DLL storage class for vtables
ClosedPublic

Authored by hans on Jun 2 2014, 1:28 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

hans updated this revision to Diff 10025.Jun 2 2014, 1:28 PM
hans retitled this revision from to Itanium ABI: Update getAddrOfVTable to set the DLL storage class for vtables.
hans updated this object.
hans edited the test plan for this revision. (Show Details)
hans added reviewers: rnk, nrieck.
hans added subscribers: Unknown Object (MLST), hansw.
rnk accepted this revision.Jun 2 2014, 2:29 PM
rnk edited edge metadata.

lgtm

test/CodeGenCXX/dllimport.cpp
530 ↗(On Diff #10025)

Can you test the case where the vtable is external? A class with a key function at -O0 should do.

In related news, we don't appear to emit available_externally vtables for classes with key functions at -O1. That seems like a bad missed optimization.

This revision is now accepted and ready to land.Jun 2 2014, 2:29 PM
hans closed this revision.Jun 2 2014, 4:21 PM
hans updated this revision to Diff 10030.

Closed by commit rL210054 (authored by @hans).