Index: lib/Sema/SemaExprObjC.cpp =================================================================== --- lib/Sema/SemaExprObjC.cpp +++ lib/Sema/SemaExprObjC.cpp @@ -564,6 +564,13 @@ BoxingMethod = StringWithUTF8StringMethod; BoxedType = NSStringPointer; + // Transfer the nullability from method's return type. + Optional Nullability = + BoxingMethod->getReturnType()->getNullability(Context); + if (Nullability) + BoxedType = Context.getAttributedType( + AttributedType::getNullabilityAttrKind(*Nullability), BoxedType, + BoxedType); } } else if (ValueType->isBuiltinType()) { // The other types we support are numeric, char and BOOL/bool. We could also Index: test/SemaObjC/transfer-boxed-string-nullability.m =================================================================== --- /dev/null +++ test/SemaObjC/transfer-boxed-string-nullability.m @@ -0,0 +1,28 @@ +// RUN: %clang_cc1 -fblocks -fobjc-arc -Wnullable-to-nonnull-conversion -fsyntax-only -verify -Wno-objc-root-class %s +// RUN: %clang_cc1 -fblocks -fobjc-arc -Wnullable-to-nonnull-conversion -fsyntax-only -verify -Wno-objc-root-class -DNOWARN %s + +@interface NSString + ++ (NSString* +#ifndef NOWARN + _Nullable +#else + _Nonnull +#endif +) stringWithUTF8String:(const char*)x; + +@end + +void takesNonNull(NSString * _Nonnull ptr); + +void testBoxedString() { + const char *str = "hey"; + takesNonNull([NSString stringWithUTF8String:str]); + takesNonNull(@(str)); +#ifndef NOWARN + // expected-warning@-3 {{implicit conversion from nullable pointer 'NSString * _Nullable' to non-nullable pointer type 'NSString * _Nonnull'}} + // expected-warning@-3 {{implicit conversion from nullable pointer 'NSString * _Nullable' to non-nullable pointer type 'NSString * _Nonnull'}} +#else + // expected-no-diagnostics +#endif +}