Page MenuHomePhabricator

Error on using dll attribute on members of class that already has a dll attribute
ClosedPublic

Authored by hans on May 30 2014, 4:03 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

hans updated this revision to Diff 9969.May 30 2014, 4:03 PM
hans retitled this revision from to Error on using dll attribute on members of class that already has a dll attribute.
hans updated this object.
hans edited the test plan for this revision. (Show Details)
hans added reviewers: nrieck, rnk.
hans added a subscriber: Unknown Object (MLST).

Forgot to mention, this depends on http://reviews.llvm.org/D3972

nrieck edited edge metadata.May 30 2014, 4:25 PM

LGTM except that this check should not be done for MinGW (and on a related note, I wish MSVC would behave the same since I can't see the benefit of this diagnostic).

include/clang/Basic/DiagnosticSemaKinds.td
2455 ↗(On Diff #9969)

Do we need a new note here? Wouldn't "previous attribute is here" suffice?

hans added a comment.May 30 2014, 7:16 PM

LGTM except that this check should not be done for MinGW (and on a related note, I wish MSVC would behave the same since I can't see the benefit of this diagnostic).

Thanks for pointing this out. I've kept it as an error for now, but maybe we want to downgrade it to a warning since nothing is breaking here, it's just a compatibility issue with MSVC.

include/clang/Basic/DiagnosticSemaKinds.td
2455 ↗(On Diff #9969)

You're right, let's just use the old note.

hans closed this revision.May 30 2014, 7:16 PM
hans updated this revision to Diff 9976.

Closed by commit rL209954 (authored by @hans).