This is an archive of the discontinued LLVM Phabricator instance.

[PredicateInfo] Stable sort ValueDFS to remove non-deterministic ordering
ClosedPublic

Authored by mgrang on Nov 4 2017, 11:47 AM.

Reviewers

Commits

Summary

This fixes failure in Transforms/Util/PredicateInfo/testandor.ll uncovered by D39245.

Ping for reviews please.

Ping 2 for reviews please.

This revision is now accepted and ready to land.Nov 14 2017, 10:17 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

trunk/

lib/

Transforms/

Utils/

2 lines

Show First 20 Lines • Show All 605 Lines • ▼ Show 20 Lines	for (auto &PossibleCopy : ValueInfo.Infos) {
VD.PInfo = PossibleCopy;		VD.PInfo = PossibleCopy;
OrderedUses.push_back(VD);		OrderedUses.push_back(VD);
}		}
}		}
}		}
}		}

convertUsesToDFSOrdered(Op, OrderedUses);		convertUsesToDFSOrdered(Op, OrderedUses);
std::sort(OrderedUses.begin(), OrderedUses.end(), Compare);		std::stable_sort(OrderedUses.begin(), OrderedUses.end(), Compare);
SmallVector<ValueDFS, 8> RenameStack;		SmallVector<ValueDFS, 8> RenameStack;
// For each use, sorted into dfs order, push values and replaces uses with		// For each use, sorted into dfs order, push values and replaces uses with
// top of stack, which will represent the reaching def.		// top of stack, which will represent the reaching def.
for (auto &VD : OrderedUses) {		for (auto &VD : OrderedUses) {
// We currently do not materialize copy over copy, but we should decide if		// We currently do not materialize copy over copy, but we should decide if
// we want to.		// we want to.
bool PossibleCopy = VD.PInfo != nullptr;		bool PossibleCopy = VD.PInfo != nullptr;
if (RenameStack.empty()) {		if (RenameStack.empty()) {
▲ Show 20 Lines • Show All 172 Lines • Show Last 20 Lines