Index: lib/AST/Decl.cpp =================================================================== --- lib/AST/Decl.cpp +++ lib/AST/Decl.cpp @@ -1514,7 +1514,10 @@ // enumerator is declared in the scope that immediately contains // the enum-specifier. Each scoped enumerator is declared in the // scope of the enumeration. - if (ED->isScoped() || ED->getIdentifier()) + // For the case of unscoped enumerator, do not include in the qualified + // name any information about its enum enclosing scope, as is visibility + // is global. + if (ED->isScoped() /*|| ED->getIdentifier()*/) OS << *ED; else continue; Index: test/Modules/odr.cpp =================================================================== --- test/Modules/odr.cpp +++ test/Modules/odr.cpp @@ -18,6 +18,6 @@ // expected-note@a.h:3 {{declaration of 'f' does not match}} // expected-note@a.h:1 {{definition has no member 'm'}} -// expected-error@b.h:5 {{'E::e2' from module 'b' is not present in definition of 'E' in module 'a'}} +// expected-error@b.h:5 {{'e2' from module 'b' is not present in definition of 'E' in module 'a'}} // expected-error@b.h:3 {{'Y::f' from module 'b' is not present in definition of 'Y' in module 'a'}} // expected-error@b.h:2 {{'Y::m' from module 'b' is not present in definition of 'Y' in module 'a'}} Index: test/SemaCXX/return-noreturn.cpp =================================================================== --- test/SemaCXX/return-noreturn.cpp +++ test/SemaCXX/return-noreturn.cpp @@ -143,7 +143,7 @@ } // expected-warning {{control reaches end of non-void function}} void PR9412_f() { - PR9412_t(); // expected-note {{in instantiation of function template specialization 'PR9412_t' requested here}} + PR9412_t(); // expected-note {{in instantiation of function template specialization 'PR9412_t' requested here}} } struct NoReturn { Index: test/SemaTemplate/temp_arg_enum_printing.cpp =================================================================== --- test/SemaTemplate/temp_arg_enum_printing.cpp +++ test/SemaTemplate/temp_arg_enum_printing.cpp @@ -13,9 +13,9 @@ void foo(); void test() { - // CHECK: template<> void foo() + // CHECK: template<> void foo() NamedEnumNS::foo(); - // CHECK: template<> void foo() + // CHECK: template<> void foo() NamedEnumNS::foo<(NamedEnum)1>(); // CHECK: template<> void foo<2>() NamedEnumNS::foo<(NamedEnum)2>(); Index: test/SemaTemplate/temp_arg_enum_printing_more.cpp =================================================================== --- test/SemaTemplate/temp_arg_enum_printing_more.cpp +++ test/SemaTemplate/temp_arg_enum_printing_more.cpp @@ -0,0 +1,26 @@ +// RUN: %clang_cc1 -fsyntax-only -ast-print %s -std=c++11 | FileCheck %s + +// Make sure that for template value arguments that are unscoped enumerators, +// no qualified enum information is included in their name, as their visibility +// is global. In the case of scoped enumerators, they must include information +// about their enum enclosing scope. + +enum E1 { e1 }; +template struct tmpl_1 {}; +// CHECK: template<> struct tmpl_1 +tmpl_1 TMPL_1; // Name must be 'e1'. + +namespace nsp_1 { enum E2 { e2 }; } +template struct tmpl_2 {}; +// CHECK: template<> struct tmpl_2 +tmpl_2 TMPL_2; // Name must be 'nsp_1::e2'. + +enum class E3 { e3 }; +template struct tmpl_3 {}; +// CHECK: template<> struct tmpl_3 +tmpl_3 TMPL_3; // Name must be 'E3::e3'. + +namespace nsp_2 { enum class E4 { e4 }; } +template struct tmpl_4 {}; +// CHECK: template<> struct tmpl_4 +tmpl_4 TMPL_4; // Name must be 'nsp_2::E4::e4'. Index: unittests/AST/NamedDeclPrinterTest.cpp =================================================================== --- unittests/AST/NamedDeclPrinterTest.cpp +++ unittests/AST/NamedDeclPrinterTest.cpp @@ -143,7 +143,7 @@ ASSERT_TRUE(PrintedWrittenNamedDeclCXX11Matches( "enum X { A };", "A", - "X::A")); + "A")); } TEST(NamedDeclPrinter, TestScopedNamedEnum) { @@ -164,7 +164,7 @@ ASSERT_TRUE(PrintedWrittenNamedDeclCXX11Matches( "class X { enum Y { A }; };", "A", - "X::Y::A")); + "X::A")); } TEST(NamedDeclPrinter, TestClassWithScopedNamedEnum) {