This is an archive of the discontinued LLVM Phabricator instance.

Add executable extension to debugger name, run dotest via binary
ClosedPublic

Authored by scottmg on May 23 2014, 5:51 PM.

Details

Reviewers
tfiala
Summary

Otherwise, when running the test suite on Windows:

  • dotest.py will be opened in editor
  • once running there'll be errors of the form ".../build/bin/lldb is not an executable"

(There are many other problems still, of course)

Diff Detail

Event Timeline

scottmg updated this revision to Diff 9783.May 23 2014, 5:51 PM
scottmg updated this revision to Diff 9784.
scottmg retitled this revision from to Add executable extension to debugger name..
scottmg updated this object.

Removed unrelated changes

scottmg retitled this revision from Add executable extension to debugger name. to Add executable extension to debugger name, run dotest via binary.May 23 2014, 5:53 PM
scottmg updated this object.
scottmg updated this object.May 23 2014, 5:57 PM
tfiala added a subscriber: tfiala.

I'm looking at this now.

tfiala accepted this revision.Jun 2 2014, 10:55 AM
tfiala edited edge metadata.

This didn't break anything on Linux x86_64 cmake/ninja with ninja && ninja check-lldb.

MacOSX dosep.ty appears fine as well.

LGTM. Submitting momentarily.

This revision is now accepted and ready to land.Jun 2 2014, 10:55 AM
tfiala closed this revision.Jun 2 2014, 10:57 AM

Submitted.

svn commit
Sending test/CMakeLists.txt
Sending test/dosep.ty
Transmitting file data ..
Committed revision 210036.