Link LLVM_PTHREAD_LIB to lldCommon

[Vulder]

Summary

The lldCommon library requires pthreads linkage.

In case of building LLVM_SHARED_LIBS we need to
link this explicitly.

Fixes issue from mailing list, posted from [e-mail].

[Vulder]

Small remark:

One could also link LLVM_PTHREAD_LIB always, to indicate the dependence to pthread.

[ruiu]

LGTM

[Vulder]

If accepted could you please also commit it? I don't have commit access.

[ruiu]

Common/CMakeLists.txt

22

Well, why can't you just add ${LLVM_PTHREAD_LIB} here?

[ruiu]

Alexander Richardson submitted https://reviews.llvm.org/rL315988 instead.

[Vulder]

Common/CMakeLists.txt

22

this should also work, like I mentioned above.

In D38999#899652, @Vulder wrote:

Small remark:

One could also link LLVM_PTHREAD_LIB always, to indicate the dependence to pthread.

Should I update or do you just take the other submission?

[Vulder]

I updated the version to always link PTHREAD

[ruiu]

The same change was submitted in https://reviews.llvm.org/rL315988 by Alexander Richardson, so we don't need to submit this patch anymore.

Common/CMakeLists.txt

add_lld_library(lldCommon
 
   LINK_COMPONENTS
   Codegen
   MC
   Option
   Support
   Target
 
+  LINK_LIBS
+  ${LLVM_PTHREAD_LIB}
+
   DEPENDS
   ${tablegen_deps}
   )