This is an archive of the discontinued LLVM Phabricator instance.

Differential D38782

[X86] Correct type for argument to clflushopt intrinsic.
ClosedPublic

Authored by craig.topper on Oct 10 2017, 10:03 PM.

Details

Reviewers
RKSimon
zvi
igorb
Commits
rG189576f80eb9: [X86] Correct type for argument to clflushopt intrinsic.
rC315470: [X86] Correct type for argument to clflushopt intrinsic.
rL315470: [X86] Correct type for argument to clflushopt intrinsic.
Summary

According to Intel docs this should take void const *. We had char*. The lack of const is the main issue.

Diff Detail

Repository
rL LLVM

Event Timeline

craig.topper created this revision.Oct 10 2017, 10:03 PM
craig.topper added reviewers: RKSimon, zvi, igorb.Oct 10 2017, 10:04 PM
craig.topper added a subscriber: llvm-commits.
igorb accepted this revision.Oct 10 2017, 11:14 PM

LGTM

This revision is now accepted and ready to land.Oct 10 2017, 11:14 PM
Closed by commit rL315470: [X86] Correct type for argument to clflushopt intrinsic. (authored by ctopper). · Explain WhyOct 11 2017, 9:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
cfe/
trunk/
include/
clang/
Basic/
2 lines
lib/
Headers/
2 lines

Diff 118630

cfe/trunk/include/clang/Basic/BuiltinsX86.def

Show First 20 Lines • Show All 633 Lines • ▼ Show 20 Lines
TARGET_BUILTIN(__builtin_ia32_xsave, "vv*ULLi", "", "xsave") TARGET_BUILTIN(__builtin_ia32_xsave, "vv*ULLi", "", "xsave")
TARGET_BUILTIN(__builtin_ia32_xrstor, "vv*ULLi", "", "xsave") TARGET_BUILTIN(__builtin_ia32_xrstor, "vv*ULLi", "", "xsave")
TARGET_BUILTIN(__builtin_ia32_xsaveopt, "vv*ULLi", "", "xsaveopt") TARGET_BUILTIN(__builtin_ia32_xsaveopt, "vv*ULLi", "", "xsaveopt")
TARGET_BUILTIN(__builtin_ia32_xrstors, "vv*ULLi", "", "xsaves") TARGET_BUILTIN(__builtin_ia32_xrstors, "vv*ULLi", "", "xsaves")
TARGET_BUILTIN(__builtin_ia32_xsavec, "vv*ULLi", "", "xsavec") TARGET_BUILTIN(__builtin_ia32_xsavec, "vv*ULLi", "", "xsavec")
TARGET_BUILTIN(__builtin_ia32_xsaves, "vv*ULLi", "", "xsaves") TARGET_BUILTIN(__builtin_ia32_xsaves, "vv*ULLi", "", "xsaves")
//CLFLUSHOPT //CLFLUSHOPT
TARGET_BUILTIN(__builtin_ia32_clflushopt, "vc*", "", "clflushopt") TARGET_BUILTIN(__builtin_ia32_clflushopt, "vvC*", "", "clflushopt")
// ADX // ADX
TARGET_BUILTIN(__builtin_ia32_addcarryx_u32, "UcUcUiUiUi*", "", "adx") TARGET_BUILTIN(__builtin_ia32_addcarryx_u32, "UcUcUiUiUi*", "", "adx")
TARGET_BUILTIN(__builtin_ia32_addcarry_u32, "UcUcUiUiUi*", "", "") TARGET_BUILTIN(__builtin_ia32_addcarry_u32, "UcUcUiUiUi*", "", "")
TARGET_BUILTIN(__builtin_ia32_subborrow_u32, "UcUcUiUiUi*", "", "") TARGET_BUILTIN(__builtin_ia32_subborrow_u32, "UcUcUiUiUi*", "", "")
// RDSEED // RDSEED
TARGET_BUILTIN(__builtin_ia32_rdseed16_step, "UiUs*", "", "rdseed") TARGET_BUILTIN(__builtin_ia32_rdseed16_step, "UiUs*", "", "rdseed")
▲ Show 20 Lines • Show All 1,179 Lines • Show Last 20 Lines

cfe/trunk/lib/Headers/clflushoptintrin.h

Show All 26 Lines
#ifndef __CLFLUSHOPTINTRIN_H #ifndef __CLFLUSHOPTINTRIN_H
#define __CLFLUSHOPTINTRIN_H #define __CLFLUSHOPTINTRIN_H
/* Define the default attributes for the functions in this file. */ /* Define the default attributes for the functions in this file. */
#define __DEFAULT_FN_ATTRS __attribute__((__always_inline__, __nodebug__, __target__("clflushopt"))) #define __DEFAULT_FN_ATTRS __attribute__((__always_inline__, __nodebug__, __target__("clflushopt")))
static __inline__ void __DEFAULT_FN_ATTRS static __inline__ void __DEFAULT_FN_ATTRS
_mm_clflushopt(char * __m) { _mm_clflushopt(void const * __m) {
__builtin_ia32_clflushopt(__m); __builtin_ia32_clflushopt(__m);
} }
#undef __DEFAULT_FN_ATTRS #undef __DEFAULT_FN_ATTRS
#endif #endif