Page MenuHomePhabricator

Fix shuffle vector lowering for generating correct vext with reversed input vectors
AcceptedPublic

Authored by Jiangning on May 22 2014, 3:00 AM.

Details

Reviewers
t.p.northover
Summary

This patch is to fix a bug around deciding if we need to reverse the two input vectors when trying to lower shuffle vector into a vext ISD node.

A new test file is added to enumerate all < 4 x i16> shufflevector masks containing two undefs.

Thanks,
-Jiangning

Diff Detail

Event Timeline

Jiangning updated this revision to Diff 9684.May 22 2014, 3:00 AM
Jiangning retitled this revision from to Fix shuffle vector lowering for generating correct vext with reversed input vectors.
Jiangning updated this object.
Jiangning edited the test plan for this revision. (Show Details)
Jiangning added a reviewer: t.p.northover.
Jiangning added a subscriber: Unknown Object (MLST).
t.p.northover accepted this revision.May 22 2014, 3:39 AM
t.p.northover edited edge metadata.

Hi Jiangning,

This looks fine to me. Nice simplification, too!

Cheers.

Tim.

This revision is now accepted and ready to land.May 22 2014, 3:39 AM