Index: lib/Transforms/Scalar/Reassociate.cpp =================================================================== --- lib/Transforms/Scalar/Reassociate.cpp +++ lib/Transforms/Scalar/Reassociate.cpp @@ -1368,21 +1368,20 @@ Value *Reassociate::OptimizeAdd(Instruction *I, SmallVectorImpl &Ops) { // Scan the operand lists looking for X and -X pairs. If we find any, we - // can simplify the expression. X+-X == 0. While we're at it, scan for any + // can simplify expressions like X+-X == 0 and X+~X ==-1. While we're at it, + // scan for any // duplicates. We want to canonicalize Y+Y+Y+Z -> 3*Y+Z. - // - // TODO: We could handle "X + ~X" -> "-1" if we wanted, since "-X = ~X+1". - // + for (unsigned i = 0, e = Ops.size(); i != e; ++i) { Value *TheOp = Ops[i].Op; // Check to see if we've seen this operand before. If so, we factor all // instances of the operand together. Due to our sorting criteria, we know // that these need to be next to each other in the vector. - if (i+1 != Ops.size() && Ops[i+1].Op == TheOp) { + if (i + 1 != Ops.size() && Ops[i + 1].Op == TheOp) { // Rescan the list, remove all instances of this operand from the expr. unsigned NumFound = 0; do { - Ops.erase(Ops.begin()+i); + Ops.erase(Ops.begin() + i); ++NumFound; } while (i != Ops.size() && Ops[i].Op == TheOp); @@ -1412,28 +1411,44 @@ continue; } - // Check for X and -X in the operand list. - if (!BinaryOperator::isNeg(TheOp)) + // Check for X and -X or X and ~X in the operand list. + if (!BinaryOperator::isNeg(TheOp) && !BinaryOperator::isNot(TheOp)) continue; - Value *X = BinaryOperator::getNegArgument(TheOp); + Value *X; + if (BinaryOperator::isNeg(TheOp)) + X = BinaryOperator::getNegArgument(TheOp); + else if (BinaryOperator::isNot(TheOp)) + X = BinaryOperator::getNotArgument(TheOp); + unsigned FoundX = FindInOperandList(Ops, i, X); if (FoundX == i) continue; // Remove X and -X from the operand list. - if (Ops.size() == 2) + if (Ops.size() == 2 && BinaryOperator::isNeg(TheOp)) return Constant::getNullValue(X->getType()); - Ops.erase(Ops.begin()+i); + // Remove X and ~X from the operand list. + if (Ops.size() == 2 && BinaryOperator::isNot(TheOp)) + return Constant::getAllOnesValue(X->getType()); + + Ops.erase(Ops.begin() + i); if (i < FoundX) --FoundX; else - --i; // Need to back up an extra one. - Ops.erase(Ops.begin()+FoundX); + --i; // Need to back up an extra one. + Ops.erase(Ops.begin() + FoundX); ++NumAnnihil; - --i; // Revisit element. - e -= 2; // Removed two elements. + --i; // Revisit element. + e -= 2; // Removed two elements. + + // if X and ~X we append -1 to the operand list. + if (BinaryOperator::isNot(TheOp)) { + Value *V = Constant::getAllOnesValue(X->getType()); + Ops.insert(Ops.end(), ValueEntry(getRank(V), V)); + e += 1; + } } // Scan the operand list, checking to see if there are any common factors @@ -1441,7 +1456,7 @@ // reassociate this to A*(A+B*C)+D, which reduces the number of multiplies. // To efficiently find this, we count the number of times a factor occurs // for any ADD operands that are MULs. - DenseMap FactorOccurrences; + DenseMap FactorOccurrences; // Keep track of each multiply we see, to avoid triggering on (X*4)+(X*4) // where they are actually the same multiply. Index: test/Transforms/Reassociate/inverses.ll =================================================================== --- test/Transforms/Reassociate/inverses.ll +++ test/Transforms/Reassociate/inverses.ll @@ -32,3 +32,15 @@ ; CHECK: %tmp.5 = add i32 %b, 1234 ; CHECK: ret i32 %tmp.5 } + +define i32 @test4(i32 %b, i32 %a) { + %tmp.1 = add i32 %a, 1234 + %tmp.2 = add i32 %b, %tmp.1 + %tmp.4 = xor i32 %a, -1 + ; (b+(a+1234))+~a -> b+1233 + %tmp.5 = add i32 %tmp.2, %tmp.4 + ret i32 %tmp.5 +; CHECK-LABEL: @test4( +; CHECK: %tmp.5 = add i32 %b, 1233 +; CHECK: ret i32 %tmp.5 +}