Index: cfe/trunk/include/clang/Basic/Attr.td =================================================================== --- cfe/trunk/include/clang/Basic/Attr.td +++ cfe/trunk/include/clang/Basic/Attr.td @@ -1665,8 +1665,7 @@ def DLLImport : InheritableAttr, TargetSpecificAttr { let Spellings = [Declspec<"dllimport">, GCC<"dllimport">]; - // Technically, the subjects for DllImport are Function and Var, but there is - // custom semantic handling required when MicrosoftExt is true. + let Subjects = SubjectList<[Function, Var]>; let Documentation = [Undocumented]; } Index: cfe/trunk/lib/Sema/SemaDeclAttr.cpp =================================================================== --- cfe/trunk/lib/Sema/SemaDeclAttr.cpp +++ cfe/trunk/lib/Sema/SemaDeclAttr.cpp @@ -3836,18 +3836,6 @@ } static void handleDLLImportAttr(Sema &S, Decl *D, const AttributeList &Attr) { - // Attribute can be applied only to functions or variables. - FunctionDecl *FD = dyn_cast(D); - if (!FD && !isa(D)) { - // Apparently Visual C++ thinks it is okay to not emit a warning - // in this case, so only emit a warning when -fms-extensions is not - // specified. - if (!S.getLangOpts().MicrosoftExt) - S.Diag(Attr.getLoc(), diag::warn_attribute_wrong_decl_type) - << Attr.getName() << ExpectedVariableOrFunction; - return; - } - unsigned Index = Attr.getAttributeSpellingListIndex(); DLLImportAttr *NewAttr = S.mergeDLLImportAttr(D, Attr.getRange(), Index); if (NewAttr) Index: cfe/trunk/test/Rewriter/dllimport-typedef.c =================================================================== --- cfe/trunk/test/Rewriter/dllimport-typedef.c +++ cfe/trunk/test/Rewriter/dllimport-typedef.c @@ -1,17 +0,0 @@ -// RUN: not %clang_cc1 -triple i686-pc-win32 -fms-extensions -fsyntax-only %s 2>&1 | FileCheck -check-prefix=CHECK-NEG %s -// RUN: not %clang_cc1 -triple i686-pc-win32 -fsyntax-only %s 2>&1 | FileCheck -check-prefix=CHECK-POS %s - -// Do not report an error with including dllimport in the typedef when -fms-extensions is specified. -// Addresses . -typedef __declspec(dllimport) int CB(void); - -// This function is added just to trigger a diagnostic. This way we can test how many -// diagnostics we expect. -void bar() { return 1; } - -// CHECK-NEG: error: void function 'bar' should not return a value -// CHECK-NEG: {{^}}1 error generated -// CHECK-POS: warning: 'dllimport' attribute only applies to variables and functions -// CHECK-POS: error: void function 'bar' should not return a value -// CHECK-POS: 1 warning and 1 error generated -