This is an archive of the discontinued LLVM Phabricator instance.

Don't move llvm.localescape outside the entry block in the GCOV profiling pass
ClosedPublic

Authored by marco-c on Sep 24 2017, 11:03 AM.

Diff Detail

Event Timeline

marco-c created this revision.Sep 24 2017, 11:03 AM
rnk accepted this revision.Sep 25 2017, 10:18 AM

lgtm

lib/Transforms/Instrumentation/GCOVProfiling.cpp
550–552

This problematically assumes that all the allocas, dbg.declare, and localescape are all in a contiguous block, but that's a pre-existing issue that you don't need to fix. In practice, clang inserts localescape after allocas.

This revision is now accepted and ready to land.Sep 25 2017, 10:18 AM
sylvestre.ledru edited the summary of this revision. (Show Details)Sep 26 2017, 4:57 AM