Index: clang-tidy/misc/SuspiciousEnumUsageCheck.cpp =================================================================== --- clang-tidy/misc/SuspiciousEnumUsageCheck.cpp +++ clang-tidy/misc/SuspiciousEnumUsageCheck.cpp @@ -42,7 +42,8 @@ const auto MinMaxVal = std::minmax_element( EnumDec->enumerator_begin(), EnumDec->enumerator_end(), [](const EnumConstantDecl *E1, const EnumConstantDecl *E2) { - return E1->getInitVal() < E2->getInitVal(); + return llvm::APSInt::compareValues(E1->getInitVal(), + E2->getInitVal()) == -1; }); MinVal = MinMaxVal.first->getInitVal(); MaxVal = MinMaxVal.second->getInitVal(); @@ -57,7 +58,9 @@ static bool hasDisjointValueRange(const EnumDecl *Enum1, const EnumDecl *Enum2) { ValueRange Range1(Enum1), Range2(Enum2); - return (Range1.MaxVal < Range2.MinVal) || (Range2.MaxVal < Range1.MinVal); + bool Less1 = llvm::APSInt::compareValues(Range1.MaxVal, Range2.MinVal) == -1; + bool Less2 = llvm::APSInt::compareValues(Range2.MaxVal, Range1.MinVal) == -1; + return Less1 || Less2; } static bool isNonPowerOf2NorNullLiteral(const EnumConstantDecl *EnumConst) { Index: test/clang-tidy/misc-suspicious-enum-usage.cpp =================================================================== --- test/clang-tidy/misc-suspicious-enum-usage.cpp +++ test/clang-tidy/misc-suspicious-enum-usage.cpp @@ -1,4 +1,4 @@ -// RUN: %check_clang_tidy %s misc-suspicious-enum-usage %t -- -config="{CheckOptions: [{key: misc-suspicious-enum-usage.StrictMode, value: 0}]}" -- +// RUN: %check_clang_tidy %s misc-suspicious-enum-usage %t -- -config="{CheckOptions: [{key: misc-suspicious-enum-usage.StrictMode, value: 0}]}" -- -std=c++11 enum Empty { }; @@ -54,7 +54,7 @@ int emptytest = EmptyVal | B; if (bestDay() | A) return 1; - // CHECK-MESSAGES: :[[@LINE-2]]:17: warning: enum values are from different enum types + // CHECK-MESSAGES: :[[@LINE-2]]:17: warning: enum values are from different enum types if (I | Y) return 1; // CHECK-MESSAGES: :[[@LINE-2]]:9: warning: enum values are from different enum types @@ -88,3 +88,41 @@ return 1; return 42; } + +// Bug #34400 +template +struct a; +template +struct c; +template +struct e; +template +struct f; +template +struct h { + typedef e i; +}; +template +struct j { + enum { k = a::l, + m }; +}; +template +struct e : j {}; +template +struct r : h::i {}; +template +struct a> { + enum { l = q }; +}; +template +struct c : r> {}; +template +struct a> { + enum { ah = ad::m, + ai = ae::m, + l = ah | ai }; + // CHECK-MESSAGES: :[[@LINE-1]]:17: warning: enum values are from different enum types +}; +template +struct f : e, c, 0>> {};