Page MenuHomePhabricator

Fix for bug 34510 - Minidump target does not resolve new symbols correctly
ClosedPublic

Authored by lemo on Sep 6 2017, 1:02 PM.

Details

Summary

Even though the content of the minidump does no change in a debugging session, frames can't be indiscriminately be cached since modules and symbols can be explicitly added after the minidump is loaded.

The fix is simple, just let the base Thread::ClearStackFrames() do it's job.

Bug: https://bugs.llvm.org/show_bug.cgi?id=34510

Differential Revision: https://reviews.llvm.org/D37527

Diff Detail

Event Timeline

lemo created this revision.Sep 6 2017, 1:02 PM
amccarth accepted this revision.Sep 6 2017, 2:12 PM

This looks fine.

Make sure you've run the LLDB tests. I don't expect this change to have much risk for breaking any of them, but it's a good habit. ninja check-lldb

For future patch reviews, please create the diffs with full context (e.g., git diff -U999999) and from the root of your source tree so that Phabricator shows paths rather than just file names.

If you're not using arc, make sure you amend your commit so that the description has a line like this:

`Differential Revision: https://reviews.llvm.org/D37527`

Capitalization and spacing are sensitive in those lines. When you push your change, that'll associate the revision with the review and close the review on the Phabricator side.

You can also mention the bug number in the description.

This revision is now accepted and ready to land.Sep 6 2017, 2:12 PM
lemo edited the summary of this revision. (Show Details)Sep 6 2017, 2:56 PM
lemo edited the summary of this revision. (Show Details)
lemo added a comment.Sep 7 2017, 11:03 AM

Thanks everyone. I don't have commit permissions, can someone please commit this on my behalf?

I'll commit it momentarily.

This revision was automatically updated to reflect the committed changes.