Index: llvm/trunk/include/llvm/Object/Decompressor.h =================================================================== --- llvm/trunk/include/llvm/Object/Decompressor.h +++ llvm/trunk/include/llvm/Object/Decompressor.h @@ -13,6 +13,7 @@ #include "llvm/ADT/SmallString.h" #include "llvm/ADT/StringRef.h" #include "llvm/Object/ObjectFile.h" +#include "llvm/Support/ErrorHandling.h" namespace llvm { namespace object { @@ -31,7 +32,9 @@ /// @brief Resize the buffer and uncompress section data into it. /// @param Out Destination buffer. template Error resizeAndDecompress(T &Out) { + install_bad_alloc_error_handler(outOfMemoryHandler, this); Out.resize(DecompressedSize); + remove_bad_alloc_error_handler(); return decompress({Out.data(), (size_t)DecompressedSize}); } @@ -52,11 +55,14 @@ static bool isGnuStyle(StringRef Name); private: - Decompressor(StringRef Data); + static void outOfMemoryHandler(void *Data, const std::string &Message, bool); + + Decompressor(StringRef Name, StringRef Data); Error consumeCompressedGnuHeader(); Error consumeCompressedZLibHeader(bool Is64Bit, bool IsLittleEndian); + StringRef SectionName; StringRef SectionData; uint64_t DecompressedSize; }; Index: llvm/trunk/lib/Object/Decompressor.cpp =================================================================== --- llvm/trunk/lib/Object/Decompressor.cpp +++ llvm/trunk/lib/Object/Decompressor.cpp @@ -23,7 +23,7 @@ if (!zlib::isAvailable()) return createError("zlib is not available"); - Decompressor D(Data); + Decompressor D(Name, Data); Error Err = isGnuStyle(Name) ? D.consumeCompressedGnuHeader() : D.consumeCompressedZLibHeader(Is64Bit, IsLE); if (Err) @@ -31,8 +31,8 @@ return D; } -Decompressor::Decompressor(StringRef Data) - : SectionData(Data), DecompressedSize(0) {} +Decompressor::Decompressor(StringRef Name, StringRef Data) + : SectionName(Name), SectionData(Data), DecompressedSize(0) {} Error Decompressor::consumeCompressedGnuHeader() { if (!SectionData.startswith("ZLIB")) @@ -92,3 +92,11 @@ size_t Size = Buffer.size(); return zlib::uncompress(SectionData, Buffer.data(), Size); } + +void Decompressor::outOfMemoryHandler(void *Data, const std::string &Message, + bool) { + const auto *D = static_cast(Data); + report_fatal_error("decompression of '" + Twine(D->SectionName) + + "' failed: unable to allocate " + + Twine(D->DecompressedSize) + " bytes."); +} Index: llvm/trunk/test/DebugInfo/dwarfdump-decompression-invalid-size.test =================================================================== --- llvm/trunk/test/DebugInfo/dwarfdump-decompression-invalid-size.test +++ llvm/trunk/test/DebugInfo/dwarfdump-decompression-invalid-size.test @@ -0,0 +1,13 @@ +// dwarfdump-decompression-invalid-size.elf-x86-64 is prepared using following +// source code and invocation: +// test.cpp: +// int main() { return 0; } +// +// gcc test.cpp -o out -g -Wl,--compress-debug-sections,zlib +// +// After that result object was modified manually. Decompressed size of +// .debug_frame section was changed to 0xffffffffffffffff in compression +// header. +RUN: not llvm-dwarfdump %p/Inputs/dwarfdump-decompression-invalid-size.elf-x86-64 2>&1 | FileCheck %s + +CHECK: decompression of '.debug_frame' failed: unable to allocate 18446744073709551615 bytes.