This is an archive of the discontinued LLVM Phabricator instance.

Paths

Fix libFuzzer flag propagation for standalone builds
ClosedPublic

Authored by george.karpenkov on Aug 28 2017, 11:40 AM.

Reviewers

kcc

Commits

Summary

Under the previous configurations, flags from SANITIZER_COMMON were not propagated under some build settings.

LGTM

This revision is now accepted and ready to land.Aug 28 2017, 12:43 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

compiler-rt/

trunk/

lib/

fuzzer/

7 lines

	Show All 24 Lines

	CHECK_CXX_SOURCE_COMPILES("			CHECK_CXX_SOURCE_COMPILES("
	static thread_local int blah;			static thread_local int blah;
	int main() {			int main() {
	return 0;			return 0;
	}			}
	" HAS_THREAD_LOCAL)			" HAS_THREAD_LOCAL)

				set(LIBFUZZER_CFLAGS ${SANITIZER_COMMON_CFLAGS})

	if (CMAKE_CXX_FLAGS MATCHES "fsanitize-coverage")			if (CMAKE_CXX_FLAGS MATCHES "fsanitize-coverage")
	set(LIBFUZZER_CFLAGS -fno-sanitize-coverage=trace-pc-guard,edge,trace-cmp,indirect-calls,8bit-counters)			list(APPEND LIBFUZZER_CFLAGS -fno-sanitize-coverage=trace-pc-guard,edge,trace-cmp,indirect-calls,8bit-counters)
	endif()			endif()

	if(NOT HAS_THREAD_LOCAL)			if(NOT HAS_THREAD_LOCAL)
	set(LIBFUZZER_CFLAGS "${LIBFUZZER_CFLAGS} -Dthread_local=__thread")			list(APPEND LIBFUZZER_CFLAGS -Dthread_local=__thread)
	endif()			endif()

	if(APPLE)			if(APPLE)
	set(FUZZER_SUPPORTED_OS osx)			set(FUZZER_SUPPORTED_OS osx)
	endif()			endif()

	add_compiler_rt_object_libraries(RTfuzzer			add_compiler_rt_object_libraries(RTfuzzer
	OS ${FUZZER_SUPPORTED_OS}			OS ${FUZZER_SUPPORTED_OS}
	Show All 29 Lines