Index: clang-tools-extra/trunk/clang-tidy/modernize/MakeSmartPtrCheck.cpp =================================================================== --- clang-tools-extra/trunk/clang-tidy/modernize/MakeSmartPtrCheck.cpp +++ clang-tools-extra/trunk/clang-tidy/modernize/MakeSmartPtrCheck.cpp @@ -262,20 +262,32 @@ break; } case CXXNewExpr::CallInit: { - // FIXME: Add fixes for constructors with initializer-list parameters. + // FIXME: Add fixes for constructors with parameters that can be created + // with a C++11 braced-init-list (e.g. std::vector, std::map). // Unlike ordinal cases, braced list can not be deduced in // std::make_smart_ptr, we need to specify the type explicitly in the fixes: // struct S { S(std::initializer_list, int); }; + // struct S2 { S2(std::vector); }; // smart_ptr(new S({1, 2, 3}, 1)); // C++98 call-style initialization // smart_ptr(new S({}, 1)); + // smart_ptr(new S2({1})); // implicit conversion: + // // std::initializer_list => std::vector // The above samples have to be replaced with: // std::make_smart_ptr(std::initializer_list({1, 2, 3}), 1); // std::make_smart_ptr(std::initializer_list({}), 1); + // std::make_smart_ptr(std::vector({1})); if (const auto *CE = New->getConstructExpr()) { for (const auto *Arg : CE->arguments()) { - if (llvm::isa(Arg)) { + if (isa(Arg)) { return false; } + // Check the implicit conversion from the std::initializer_list type to + // a class type. + if (const auto *ImplicitCE = dyn_cast(Arg)) { + if (ImplicitCE->isStdInitListInitialization()) { + return false; + } + } } } if (ArraySizeExpr.empty()) { Index: clang-tools-extra/trunk/test/clang-tidy/Inputs/modernize-smart-ptr/initializer_list.h =================================================================== --- clang-tools-extra/trunk/test/clang-tidy/Inputs/modernize-smart-ptr/initializer_list.h +++ clang-tools-extra/trunk/test/clang-tidy/Inputs/modernize-smart-ptr/initializer_list.h @@ -22,4 +22,10 @@ const _E *begin() const { return __begin_; } const _E *end() const { return __begin_ + __size_; } }; + +template +class vector { + public: + vector(initializer_list<_E> init); +}; } // namespace std Index: clang-tools-extra/trunk/test/clang-tidy/modernize-make-unique.cpp =================================================================== --- clang-tools-extra/trunk/test/clang-tidy/modernize-make-unique.cpp +++ clang-tools-extra/trunk/test/clang-tidy/modernize-make-unique.cpp @@ -43,6 +43,14 @@ G(int); }; +struct H { + H(std::vector); +}; + +struct I { + I(G); +}; + namespace { class Foo {}; } // namespace @@ -316,6 +324,20 @@ // CHECK-MESSAGES: :[[@LINE-1]]:28: warning: use std::make_unique instead // CHECK-FIXES: std::unique_ptr PG3 = std::unique_ptr(new G{1, 2}); + std::unique_ptr PH1 = std::unique_ptr(new H({1, 2, 3})); + // CHECK-MESSAGES: :[[@LINE-1]]:28: warning: use std::make_unique instead + // CHECK-FIXES: std::unique_ptr PH1 = std::unique_ptr(new H({1, 2, 3})); + PH1.reset(new H({1, 2, 3})); + // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: use std::make_unique instead + // CHECK-FIXES: PH1.reset(new H({1, 2, 3})); + + std::unique_ptr PI1 = std::unique_ptr(new I(G({1, 2, 3}))); + // CHECK-MESSAGES: :[[@LINE-1]]:28: warning: use std::make_unique instead + // CHECK-FIXES: std::unique_ptr PI1 = std::make_unique(G({1, 2, 3})); + PI1.reset(new I(G({1, 2, 3}))); + // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: use std::make_unique instead + // CHECK-FIXES: PI1 = std::make_unique(G({1, 2, 3})); + std::unique_ptr FF = std::unique_ptr(new Foo()); // CHECK-MESSAGES: :[[@LINE-1]]:29: warning: // CHECK-FIXES: std::unique_ptr FF = std::make_unique();