Index: compiler-rt/trunk/lib/tsan/check_analyze.sh =================================================================== --- compiler-rt/trunk/lib/tsan/check_analyze.sh +++ compiler-rt/trunk/lib/tsan/check_analyze.sh @@ -2,6 +2,14 @@ # # Script that checks that critical functions in TSan runtime have correct number # of push/pop/rsp instructions to verify that runtime is efficient enough. +# +# This test can fail when backend code generation changes the output for various +# tsan interceptors. When such a change happens, you can ensure that the +# performance has not regressed by running the following benchmarks before and +# after the breaking change to verify that the values in this file are safe to +# update: +# ./projects/compiler-rt/lib/tsan/tests/rtl/TsanRtlTest +# --gtest_also_run_disabled_tests --gtest_filter=DISABLED_BENCH.Mop* set -u @@ -35,7 +43,7 @@ for f in read1 read2 read4 read8; do check $f rsp 1 check $f push 3 - check $f pop 3 + check $f pop 18 done for f in func_entry func_exit; do