Index: clang-tidy/android/CloexecCreatCheck.h =================================================================== --- clang-tidy/android/CloexecCreatCheck.h +++ clang-tidy/android/CloexecCreatCheck.h @@ -10,7 +10,7 @@ #ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_ANDROID_CLOEXEC_CREAT_H #define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_ANDROID_CLOEXEC_CREAT_H -#include "../ClangTidy.h" +#include "CloexecCheck.h" namespace clang { namespace tidy { @@ -20,10 +20,10 @@ /// Find the usage of creat() and redirect user to use open(). /// http://clang.llvm.org/extra/clang-tidy/checks/android-cloexec-creat.html -class CloexecCreatCheck : public ClangTidyCheck { +class CloexecCreatCheck : public CloexecCheck { public: CloexecCreatCheck(StringRef Name, ClangTidyContext *Context) - : ClangTidyCheck(Name, Context) {} + : CloexecCheck(Name, Context) {} void registerMatchers(ast_matchers::MatchFinder *Finder) override; void check(const ast_matchers::MatchFinder::MatchResult &Result) override; }; Index: clang-tidy/android/CloexecCreatCheck.cpp =================================================================== --- clang-tidy/android/CloexecCreatCheck.cpp +++ clang-tidy/android/CloexecCreatCheck.cpp @@ -10,7 +10,6 @@ #include "CloexecCreatCheck.h" #include "clang/AST/ASTContext.h" #include "clang/ASTMatchers/ASTMatchFinder.h" -#include "clang/Lex/Lexer.h" using namespace clang::ast_matchers; @@ -21,37 +20,22 @@ void CloexecCreatCheck::registerMatchers(MatchFinder *Finder) { auto CharPointerType = hasType(pointerType(pointee(isAnyCharacter()))); auto MODETType = hasType(namedDecl(hasName("mode_t"))); - - Finder->addMatcher( - callExpr(callee(functionDecl(isExternC(), returns(isInteger()), - hasName("creat"), - hasParameter(0, CharPointerType), - hasParameter(1, MODETType)) - .bind("funcDecl"))) - .bind("creatFn"), - this); + registerMatchersImpl(Finder, + functionDecl(isExternC(), returns(isInteger()), + hasName("creat"), + hasParameter(0, CharPointerType), + hasParameter(1, MODETType))); } void CloexecCreatCheck::check(const MatchFinder::MatchResult &Result) { - const auto *MatchedCall = Result.Nodes.getNodeAs("creatFn"); - const SourceManager &SM = *Result.SourceManager; - const std::string &ReplacementText = - (Twine("open (") + - Lexer::getSourceText(CharSourceRange::getTokenRange( - MatchedCall->getArg(0)->getSourceRange()), - SM, Result.Context->getLangOpts()) + + (Twine("open (") + getSpellingArg(Result, 0) + ", O_WRONLY | O_CREAT | O_TRUNC | O_CLOEXEC, " + - Lexer::getSourceText(CharSourceRange::getTokenRange( - MatchedCall->getArg(1)->getSourceRange()), - SM, Result.Context->getLangOpts()) + - ")") + getSpellingArg(Result, 1) + ")") .str(); - - diag(MatchedCall->getLocStart(), - "prefer open() to creat() because open() allows O_CLOEXEC") - << FixItHint::CreateReplacement(MatchedCall->getSourceRange(), - ReplacementText); + replaceFunc(Result, + "prefer open() to creat() because open() allows O_CLOEXEC", + ReplacementText); } } // namespace android