Page MenuHomePhabricator

[ARM64] Check for proper immediate in shift/extend operands
ClosedPublic

Authored by bsmith on May 8 2014, 3:58 AM.

Details

Summary

This fixes an assertion failure when using a negative immediate after a shift or extend operand.

There is no testcase for this fix since it is part of porting over MC/AArch64/basic-a64-diagnostics.s, which will be enabled for ARM64 once everything is fixed in it.

Diff Detail

Event Timeline

bsmith updated this revision to Diff 9204.May 8 2014, 3:58 AM
bsmith retitled this revision from to [ARM64] Check for proper immediate in shift/extend operands.
bsmith updated this object.
bsmith edited the test plan for this revision. (Show Details)
bsmith added a reviewer: t.p.northover.
bsmith set the repository for this revision to rL LLVM.
bsmith added a subscriber: Unknown Object (MLST).
t.p.northover edited edge metadata.May 8 2014, 4:21 AM

Hi Bradley,

This looks reasonable to me.

Cheers.

Tim.

bsmith accepted this revision.May 8 2014, 8:48 AM
bsmith added a reviewer: bsmith.
This revision is now accepted and ready to land.May 8 2014, 8:48 AM
bsmith closed this revision.May 8 2014, 8:48 AM