Index: include/clang/Basic/DiagnosticParseKinds.td =================================================================== --- include/clang/Basic/DiagnosticParseKinds.td +++ include/clang/Basic/DiagnosticParseKinds.td @@ -96,12 +96,16 @@ InGroup, DefaultIgnore; def warn_cxx98_compat_alignof : Warning< "alignof expressions are incompatible with C++98">, - InGroup, DefaultIgnore; -def ext_alignof_expr : ExtWarn< - "%0 applied to an expression is a GNU extension">, InGroup; - -def warn_microsoft_dependent_exists : Warning< - "dependent %select{__if_not_exists|__if_exists}0 declarations are ignored">, + InGroup, DefaultIgnore; +def ext_alignof_expr : ExtWarn< + "%0 applied to an expression is a GNU extension">, InGroup; +def err_lambda_after_delete : Error< + "'[]' after delete interpreted as 'delete[]'">; +def note_lambda_after_delete : Note< + "add parentheses around the lambda">; + +def warn_microsoft_dependent_exists : Warning< + "dependent %select{__if_not_exists|__if_exists}0 declarations are ignored">, InGroup>; def warn_microsoft_qualifiers_ignored : Warning< "qualifiers after comma in declarator list are ignored">, Index: lib/Parse/ParseExprCXX.cpp =================================================================== --- lib/Parse/ParseExprCXX.cpp +++ lib/Parse/ParseExprCXX.cpp @@ -2901,15 +2901,45 @@ // [Footnote: A lambda expression with a lambda-introducer that consists // of empty square brackets can follow the delete keyword if // the lambda expression is enclosed in parentheses.] - // FIXME: Produce a better diagnostic if the '[]' is unambiguously a - // lambda-introducer. - ArrayDelete = true; - BalancedDelimiterTracker T(*this, tok::l_square); + TentativeParsingAction TPA(*this); - T.consumeOpen(); - T.consumeClose(); - if (T.getCloseLocation().isInvalid()) - return ExprError(); + // Basic lookahead to check if we have a lambda expression. If we + // encounter two braces with a semicolon, we can be pretty sure + // that this is a lambda, not say a compound literal. + if (!SkipUntil(tok::l_brace, SkipUntilFlags::StopAtSemi) || + (NextToken().isNot(tok::r_brace) && !SkipUntil(tok::semi)) || + !SkipUntil(tok::r_brace, SkipUntilFlags::StopAtSemi)) { + TPA.Revert(); + ArrayDelete = true; + BalancedDelimiterTracker T(*this, tok::l_square); + + T.consumeOpen(); + T.consumeClose(); + if (T.getCloseLocation().isInvalid()) + return ExprError(); + } else { + TPA.Revert(); + + // Warn if the non-capturing lambda isn't surrounded by parenthesis + // to disambiguate it from 'delete[]'. + ExprResult Lambda = TryParseLambdaExpression(); + if (!Lambda.isInvalid()) { + SourceLocation StartLoc = Lambda.get()->getLocStart(); + Diag(Start, diag::err_lambda_after_delete) + << SourceRange(Start, StartLoc.getLocWithOffset(1)); + + SourceLocation BeforeBracket = StartLoc.getLocWithOffset(-1); + Diag(BeforeBracket, diag::note_lambda_after_delete) + << FixItHint::CreateInsertion(BeforeBracket, "(") + << FixItHint::CreateInsertion( + Lambda.get()->getLocEnd().getLocWithOffset(1), ")"); + + // Evaluate any postfix expressions used on the lambda. + Lambda = ParsePostfixExpressionSuffix(Lambda); + return Actions.ActOnCXXDelete(Start, UseGlobal, /*ArrayForm=*/false, + Lambda.get()); + } + } } ExprResult Operand(ParseCastExpression(false)); Index: test/Parser/cxx0x-lambda-expressions.cpp =================================================================== --- test/Parser/cxx0x-lambda-expressions.cpp +++ test/Parser/cxx0x-lambda-expressions.cpp @@ -53,7 +53,8 @@ void delete_lambda(int *p) { delete [] p; delete [] (int*) { new int }; // ok, compound-literal, not lambda - delete [] { return new int; } (); // expected-error{{expected expression}} + delete [] { return new int; } (); // expected-error {{'[]' after delete interpreted as 'delete[]'}} + // expected-note@-1 {{add parentheses around the lambda}} delete [&] { return new int; } (); // ok, lambda } Index: test/SemaCXX/new-delete-0x.cpp =================================================================== --- test/SemaCXX/new-delete-0x.cpp +++ test/SemaCXX/new-delete-0x.cpp @@ -31,9 +31,9 @@ delete [&]{ return (int*)0; }(); } -void bad_deletes() -{ - // 'delete []' is always array delete, per [expr.delete]p1. - // FIXME: Give a better diagnostic. - delete []{ return (int*)0; }(); // expected-error {{expected expression}} -} +void bad_deletes() +{ + // 'delete []' is always array delete, per [expr.delete]p1. + delete []{ return (int*)0; }(); // expected-error {{'[]' after delete interpreted as 'delete[]'}} + // expected-note@-1 {{add parentheses around the lambda}} +} \ No newline at end of file