This is an archive of the discontinued LLVM Phabricator instance.

Modify the annotation for the PrintStackTraceOnErrorSignal() in the llvm/include/llvm/Support/Signals.h.
AbandonedPublic

Authored by MTC on Aug 4 2017, 10:35 AM.

Details

Summary

Modify the annotation for the llvm/include/llvm/Support/Signals.h, there is no signal named SIBABRT.

Event Timeline

MTC created this revision.Aug 4 2017, 10:35 AM
rnk edited edge metadata.Aug 4 2017, 10:50 AM

Looks good but I do not have time to apply this

MTC added a reviewer: kcc.Aug 4 2017, 11:18 AM
MTC added a reviewer: Ayal.Aug 5 2017, 4:33 AM
MTC added a comment.Aug 9 2017, 6:48 AM
In D36329#832240, @rnk wrote:

Looks good but I do not have time to apply this

Hi rnk,
Thanks for the reveiw. This is just a small flaw in llvm and does not need to fix it at once.

MTC abandoned this revision.Jan 17 2018, 9:28 PM

I just noticed this was never committed. I found another one and committed it here:

echristo@jhereg ~/s/llvm> git svn dcommit
Committing to https://llvm.org/svn/llvm-project/llvm/trunk ...
Password for 'echristo':
M include/llvm/Support/Signals.h
M lib/Support/Windows/Signals.inc
Committed r322902