Page MenuHomePhabricator

[llvm-cov] Rearrange entries in HTML report index.
ClosedPublic

Authored by efriedma on Aug 3 2017, 6:35 PM.

Details

Summary

Files which don't contain any functions are likely useless; don't include them in the main table. Put the links at the bottom of the page, in case someone wants to figure out coverage for code inside a macro.

Not sure if this is the best solution, but it seems like an improvement.

Diff Detail

Event Timeline

efriedma created this revision.Aug 3 2017, 6:35 PM
vsk edited edge metadata.Aug 3 2017, 7:18 PM

This seems like a clean solution. The total file coverage summaries aren't affected, which is nice.

Could you make a similar change to CoverageReport::prepareFileReports? We try to maintain parity between the text/html emitters, and the text emitter uses CoverageReport to prepare its index file. This should do it:

.

You could add a RUN line to the test you've updated here, and use -format text, to get a test case. None of the other tests appear to be affected.

efriedma updated this revision to Diff 110277.Aug 8 2017, 2:30 PM

Update text reports.

vsk accepted this revision.Aug 8 2017, 2:31 PM

Thanks, lgtm.

This revision is now accepted and ready to land.Aug 8 2017, 2:31 PM
This revision was automatically updated to reflect the committed changes.