This is an archive of the discontinued LLVM Phabricator instance.

Differential D36192

[tsan] Fix format string in WriteMemoryProfile
ClosedPublic

Authored by kubamracek on Aug 1 2017, 2:45 PM.

Details

Reviewers
dvyukov
Commits
rG507b1e280cf5: [tsan] Fix format string in WriteMemoryProfile
rCRT310276: [tsan] Fix format string in WriteMemoryProfile
rL310276: [tsan] Fix format string in WriteMemoryProfile
Summary

The current format string is broken and fails to parse.

Diff Detail

Repository
rL LLVM

Event Timeline

kubamracek created this revision.Aug 1 2017, 2:45 PM
dvyukov accepted this revision.Aug 1 2017, 11:08 PM
This revision is now accepted and ready to land.Aug 1 2017, 11:08 PM
Closed by commit rL310276: [tsan] Fix format string in WriteMemoryProfile (authored by kuba.brecka). · Explain WhyAug 7 2017, 11:13 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
compiler-rt/
trunk/
lib/
tsan/
rtl/
4 lines

Diff 110036

compiler-rt/trunk/lib/tsan/rtl/tsan_platform_mac.cc

Show First 20 Lines • Show All 161 Lines • ▼ Show 20 Lines internal_snprintf(buf, buf_size,
"traces (0x%016zx-0x%016zx): resident %zd kB, dirty %zd kB\n" "traces (0x%016zx-0x%016zx): resident %zd kB, dirty %zd kB\n"
#if !SANITIZER_GO #if !SANITIZER_GO
"low app (0x%016zx-0x%016zx): resident %zd kB, dirty %zd kB\n" "low app (0x%016zx-0x%016zx): resident %zd kB, dirty %zd kB\n"
"high app (0x%016zx-0x%016zx): resident %zd kB, dirty %zd kB\n" "high app (0x%016zx-0x%016zx): resident %zd kB, dirty %zd kB\n"
"heap (0x%016zx-0x%016zx): resident %zd kB, dirty %zd kB\n" "heap (0x%016zx-0x%016zx): resident %zd kB, dirty %zd kB\n"
#else // !SANITIZER_GO #else // !SANITIZER_GO
"app (0x%016zx-0x%016zx): resident %zd kB, dirty %zd kB\n" "app (0x%016zx-0x%016zx): resident %zd kB, dirty %zd kB\n"
#endif #endif
"stacks: %ld unique IDs, %ld kB allocated\n" "stacks: %zd unique IDs, %zd kB allocated\n"
"threads: %ld total, %ld live\n" "threads: %zd total, %zd live\n"
"------------------------------\n", "------------------------------\n",
ShadowBeg(), ShadowEnd(), shadow_res / 1024, shadow_dirty / 1024, ShadowBeg(), ShadowEnd(), shadow_res / 1024, shadow_dirty / 1024,
MetaShadowBeg(), MetaShadowEnd(), meta_res / 1024, meta_dirty / 1024, MetaShadowBeg(), MetaShadowEnd(), meta_res / 1024, meta_dirty / 1024,
TraceMemBeg(), TraceMemEnd(), trace_res / 1024, trace_dirty / 1024, TraceMemBeg(), TraceMemEnd(), trace_res / 1024, trace_dirty / 1024,
#if !SANITIZER_GO #if !SANITIZER_GO
LoAppMemBeg(), LoAppMemEnd(), low_res / 1024, low_dirty / 1024, LoAppMemBeg(), LoAppMemEnd(), low_res / 1024, low_dirty / 1024,
HiAppMemBeg(), HiAppMemEnd(), high_res / 1024, high_dirty / 1024, HiAppMemBeg(), HiAppMemEnd(), high_res / 1024, high_dirty / 1024,
HeapMemBeg(), HeapMemEnd(), heap_res / 1024, heap_dirty / 1024, HeapMemBeg(), HeapMemEnd(), heap_res / 1024, heap_dirty / 1024,
▲ Show 20 Lines • Show All 118 Lines • Show Last 20 Lines