Page MenuHomePhabricator

Fix ASan issue 305 -- don't instrument .CRT initializer/terminator callbacks
ClosedPublic

Authored by timurrrr on May 5 2014, 6:52 AM.

Details

Diff Detail

Event Timeline

timurrrr updated this revision to Diff 9071.May 5 2014, 6:52 AM
timurrrr retitled this revision from to Fix ASan issue 305 -- don't instrument .CRT initializer/terminator callbacks.
timurrrr updated this object.
timurrrr edited the test plan for this revision. (Show Details)
timurrrr added a reviewer: glider.
timurrrr added a subscriber: Unknown Object (MLST).
glider edited edge metadata.May 5 2014, 7:02 AM

LGTM.
Please add a link to the CRT documentation (e.g. http://msdn.microsoft.com/ru-ru/library/bb918180(v=vs.100).aspx) and make sure there's a test.

glider accepted this revision.May 5 2014, 7:02 AM
glider edited edge metadata.
This revision is now accepted and ready to land.May 5 2014, 7:02 AM
timurrrr closed this revision.May 5 2014, 7:36 AM

r207968.

I've added the link to MSDN and (as discussed offline) relaxed the name check a little bit.

Will commit a test separately.