Page MenuHomePhabricator

[ARM64] Select ANDWri correctly in FastISel
ClosedPublic

Authored by joey on May 2 2014, 4:00 PM.

Details

Summary

Pretty mechanical patch to fix the selection of ANDWri.

I didn't add new tests because the all the code I touched is currently exercised by the tests. I just can't add -verify-machineinstrs everywhere just yet. Should I add specific tests for the cases? I'm working towards adding -verify-machineinstrs to more tests, so they should be guarded soon.

Diff Detail

Event Timeline

joey updated this revision to Diff 9047.May 2 2014, 4:00 PM
joey retitled this revision from to [ARM64] Select ANDWri correctly in FastISel.
joey updated this object.
joey edited the test plan for this revision. (Show Details)
joey added reviewers: grosbach, t.p.northover.
joey set the repository for this revision to rL LLVM.
joey added a subscriber: Unknown Object (MLST).
t.p.northover edited edge metadata.May 2 2014, 11:18 PM

Hi Joey,

This code looks fine. From my perspective, as long there's *some* test (adding -verify-machineinstrs here is fine) and we're making progress towards enabling verify on everything, it's probably OK.

Cheers.

Tim.

t.p.northover accepted this revision.May 2 2014, 11:18 PM
t.p.northover edited edge metadata.
This revision is now accepted and ready to land.May 2 2014, 11:18 PM
joey closed this revision.May 3 2014, 10:37 AM

Thanks Tim! r207917