This is an archive of the discontinued LLVM Phabricator instance.

Differential D35762

[Bash-autocompletion] Fixed typo and add '-' after -Wno
ClosedPublic

Authored by yamaguchi on Jul 22 2017, 5:03 AM.

Details

Reviewers
v.g.vassilev
teemperor
Commits
rG5f3aa46d7d37: Merging r308824: --------------------------------------------------------------…
rGb40f4db4afee: [Bash-autocompletion] Fixed typo and add '-' after -Wno
rC308824: [Bash-autocompletion] Fixed typo and add '-' after -Wno
rL309130: Merging r308824:
rL308824: [Bash-autocompletion] Fixed typo and add '-' after -Wno
Summary

-Wno-<warning> was autocompleted as -Wno<warning>, so fixed this typo.

Diff Detail

Repository
rL LLVM

Event Timeline

yamaguchi created this revision.Jul 22 2017, 5:03 AM
teemperor accepted this revision.Jul 22 2017, 5:23 AM

Thanks for the quick fix, LGTM!

This revision is now accepted and ready to land.Jul 22 2017, 5:23 AM
Closed by commit rL308824: [Bash-autocompletion] Fixed typo and add '-' after -Wno (authored by yamaguchi). · Explain WhyJul 22 2017, 5:36 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
cfe/
trunk/
lib/
Basic/
2 lines
test/
Driver/
4 lines

Diff 107782

cfe/trunk/lib/Basic/DiagnosticIDs.cpp

Show First 20 Lines • Show All 510 Lines • ▼ Show 20 Lines
} }
std::vector<std::string> DiagnosticIDs::getDiagnosticFlags() { std::vector<std::string> DiagnosticIDs::getDiagnosticFlags() {
std::vector<std::string> Res; std::vector<std::string> Res;
for (size_t I = 1; DiagGroupNames[I] != '\0';) { for (size_t I = 1; DiagGroupNames[I] != '\0';) {
std::string Diag(DiagGroupNames + I + 1, DiagGroupNames[I]); std::string Diag(DiagGroupNames + I + 1, DiagGroupNames[I]);
I += DiagGroupNames[I] + 1; I += DiagGroupNames[I] + 1;
Res.push_back("-W" + Diag); Res.push_back("-W" + Diag);
Res.push_back("-Wno" + Diag); Res.push_back("-Wno-" + Diag);
} }
return Res; return Res;
} }
/// Return \c true if any diagnostics were found in this group, even if they /// Return \c true if any diagnostics were found in this group, even if they
/// were filtered out due to having the wrong flavor. /// were filtered out due to having the wrong flavor.
static bool getDiagnosticsInGroup(diag::Flavor Flavor, static bool getDiagnosticsInGroup(diag::Flavor Flavor,
▲ Show 20 Lines • Show All 201 Lines • Show Last 20 Lines

cfe/trunk/test/Driver/autocomplete.c

Show All 36 Lines
// RUN: %clang --autocomplete=-mrelocation-model, | FileCheck %s -check-prefix=MRELOCMODELALL // RUN: %clang --autocomplete=-mrelocation-model, | FileCheck %s -check-prefix=MRELOCMODELALL
// MRELOCMODELALL: dynamic-no-pic pic ropi ropi-rwpi rwpi static // MRELOCMODELALL: dynamic-no-pic pic ropi ropi-rwpi rwpi static
// RUN: %clang --autocomplete=-mrelocation-mode | FileCheck %s -check-prefix=MRELOCMODEL_CLANG // RUN: %clang --autocomplete=-mrelocation-mode | FileCheck %s -check-prefix=MRELOCMODEL_CLANG
// MRELOCMODEL_CLANG-NOT: -mrelocation-model // MRELOCMODEL_CLANG-NOT: -mrelocation-model
// RUN: %clang --autocomplete=#-mrelocation-mode | FileCheck %s -check-prefix=MRELOCMODEL_CC1 // RUN: %clang --autocomplete=#-mrelocation-mode | FileCheck %s -check-prefix=MRELOCMODEL_CC1
// MRELOCMODEL_CC1: -mrelocation-model // MRELOCMODEL_CC1: -mrelocation-model
// RUN: %clang --autocomplete=-Wma | FileCheck %s -check-prefix=WARNING // RUN: %clang --autocomplete=-Wma | FileCheck %s -check-prefix=WARNING
// WARNING: -Wmacro-redefined -Wmain -Wmain-return-type -Wmalformed-warning-check -Wmany-braces-around-scalar-init -Wmax-unsigned-zero // WARNING: -Wmacro-redefined -Wmain -Wmain-return-type -Wmalformed-warning-check -Wmany-braces-around-scalar-init -Wmax-unsigned-zero
// RUN: %clang --autocomplete=-Wnoinvalid-pp- | FileCheck %s -check-prefix=NOWARNING // RUN: %clang --autocomplete=-Wno-invalid-pp- | FileCheck %s -check-prefix=NOWARNING
// NOWARNING: -Wnoinvalid-pp-token // NOWARNING: -Wno-invalid-pp-token