Index: clang-tidy/android/AndroidTidyModule.cpp =================================================================== --- clang-tidy/android/AndroidTidyModule.cpp +++ clang-tidy/android/AndroidTidyModule.cpp @@ -12,6 +12,7 @@ #include "../ClangTidyModuleRegistry.h" #include "CloexecCreatCheck.h" #include "CloexecFopenCheck.h" +#include "CloexecInotifyInitCheck.h" #include "CloexecOpenCheck.h" #include "CloexecSocketCheck.h" @@ -27,6 +28,8 @@ void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override { CheckFactories.registerCheck("android-cloexec-creat"); CheckFactories.registerCheck("android-cloexec-fopen"); + CheckFactories.registerCheck( + "android-cloexec-inotify-init"); CheckFactories.registerCheck("android-cloexec-open"); CheckFactories.registerCheck("android-cloexec-socket"); } Index: clang-tidy/android/CMakeLists.txt =================================================================== --- clang-tidy/android/CMakeLists.txt +++ clang-tidy/android/CMakeLists.txt @@ -4,6 +4,7 @@ AndroidTidyModule.cpp CloexecCreatCheck.cpp CloexecFopenCheck.cpp + CloexecInotifyInitCheck.cpp CloexecOpenCheck.cpp CloexecSocketCheck.cpp Index: clang-tidy/android/CloexecInotifyInitCheck.h =================================================================== --- /dev/null +++ clang-tidy/android/CloexecInotifyInitCheck.h @@ -0,0 +1,35 @@ +//===--- CloexecInotifyInitCheck.h - clang-tidy------------------*- C++ -*-===// +// +// The LLVM Compiler Infrastructure +// +// This file is distributed under the University of Illinois Open Source +// License. See LICENSE.TXT for details. +// +//===----------------------------------------------------------------------===// + +#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_ANDROID_CLOEXEC_INOTIFY_INIT_H +#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_ANDROID_CLOEXEC_INOTIFY_INIT_H + +#include "../ClangTidy.h" + +namespace clang { +namespace tidy { +namespace android { + +/// inotify_init() is better to be replaced by inotify_init1(). +/// +/// For the user-facing documentation see: +/// http://clang.llvm.org/extra/clang-tidy/checks/android-cloexec-inotify-init.html +class CloexecInotifyInitCheck : public ClangTidyCheck { +public: + CloexecInotifyInitCheck(StringRef Name, ClangTidyContext *Context) + : ClangTidyCheck(Name, Context) {} + void registerMatchers(ast_matchers::MatchFinder *Finder) override; + void check(const ast_matchers::MatchFinder::MatchResult &Result) override; +}; + +} // namespace android +} // namespace tidy +} // namespace clang + +#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_ANDROID_CLOEXEC_INOTIFY_INIT_H Index: clang-tidy/android/CloexecInotifyInitCheck.cpp =================================================================== --- /dev/null +++ clang-tidy/android/CloexecInotifyInitCheck.cpp @@ -0,0 +1,40 @@ +//===--- CloexecInotifyInitCheck.cpp - clang-tidy--------------------------===// +// +// The LLVM Compiler Infrastructure +// +// This file is distributed under the University of Illinois Open Source +// License. See LICENSE.TXT for details. +// +//===----------------------------------------------------------------------===// + +#include "CloexecInotifyInitCheck.h" +#include "clang/AST/ASTContext.h" +#include "clang/ASTMatchers/ASTMatchFinder.h" + +using namespace clang::ast_matchers; + +namespace clang { +namespace tidy { +namespace android { + +void CloexecInotifyInitCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( + callExpr(callee(functionDecl(isExternC(), returns(isInteger()), + hasName("inotify_init")) + .bind("funcDecl"))) + .bind("inotifyInitFn"), + this); +} + +void CloexecInotifyInitCheck::check(const MatchFinder::MatchResult &Result) { + const auto *MatchedCall = Result.Nodes.getNodeAs("inotifyInitFn"); + + diag(MatchedCall->getLocStart(), "prefer inotify_init() to inotify_init1() " + "because inotify_init1() allows IN_CLOEXEC") + << FixItHint::CreateReplacement(MatchedCall->getSourceRange(), + "inotify_init1(IN_CLOEXEC)"); +} + +} // namespace android +} // namespace tidy +} // namespace clang Index: docs/ReleaseNotes.rst =================================================================== --- docs/ReleaseNotes.rst +++ docs/ReleaseNotes.rst @@ -73,6 +73,11 @@ Checks if the required mode ``e`` exists in the mode argument of ``fopen()``. +- New `android-cloexec-inotify-init + `_ check + + Detects usage of ``inotify_init()``. + - New `android-cloexec-socket `_ check Index: docs/clang-tidy/checks/android-cloexec-inotify-init.rst =================================================================== --- /dev/null +++ docs/clang-tidy/checks/android-cloexec-inotify-init.rst @@ -0,0 +1,17 @@ +.. title:: clang-tidy - android-cloexec-inotify-init + +android-cloexec-inotify-init +============================ + +The usage of ``inotify_init()`` is not recommended, it's better to use +``inotify_init1()``. + +Examples: + +.. code-block:: c++ + + inotify_init(); + + // becomes + + inotify_init1(IN_CLOEXEC); Index: docs/clang-tidy/checks/list.rst =================================================================== --- docs/clang-tidy/checks/list.rst +++ docs/clang-tidy/checks/list.rst @@ -6,6 +6,7 @@ .. toctree:: android-cloexec-creat android-cloexec-fopen + android-cloexec-inotify-init android-cloexec-open android-cloexec-socket boost-use-to-string Index: test/clang-tidy/android-cloexec-inotify-init.cpp =================================================================== --- /dev/null +++ test/clang-tidy/android-cloexec-inotify-init.cpp @@ -0,0 +1,24 @@ +// RUN: %check_clang_tidy %s android-cloexec-inotify-init %t + +extern "C" int inotify_init(); + +void f() { + inotify_init(); + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: prefer inotify_init() to inotify_init1() because inotify_init1() allows IN_CLOEXEC [android-cloexec-inotify-init] + // CHECK-FIXES: inotify_init1(IN_CLOEXEC) +} + +namespace i { +int inotify_init(); +void g() { + inotify_init(); +} +} // namespace i + +class C { +public: + int inotify_init(); + void h() { + inotify_init(); + } +};