This is an archive of the discontinued LLVM Phabricator instance.

Differential D35151

[pdbutil] Only output color diff if the stream supports it
AbandonedPublic

Authored by sbc100 on Jul 7 2017, 2:58 PM.

Details

Reviewers
zturner
Summary

This (partially at least) fixes lld/test/COFF/pdb-diff.test

Diff Detail

Event Timeline

sbc100 created this revision.Jul 7 2017, 2:58 PM
sbc100 added a subscriber: llvm-commits.Jul 7 2017, 2:59 PM
Harbormaster completed remote builds in B8067: Diff 105707.Jul 9 2017, 6:15 AM
sbc100 abandoned this revision.Jul 10 2017, 9:24 AM

Revision Contents

PathSize
tools/
llvm-pdbutil/
2 lines

Diff 105707

tools/llvm-pdbutil/DiffPrinter.cpp

Show First 20 Lines • Show All 117 Lines • ▼ Show 20 Linesvoid DiffPrinter::printValue(StringRef Value, DiffResult C, AlignStyle Style,
if (!Force && !PrintValues) if (!Force && !PrintValues)
return; return;
if (Style == AlignStyle::Right) if (Style == AlignStyle::Right)
--Width; --Width;
std::string FormattedItem = std::string FormattedItem =
formatv("{0}", fmt_align(Value, Style, Width)).str(); formatv("{0}", fmt_align(Value, Style, Width)).str();
if (C != DiffResult::UNSPECIFIED) { if (C != DiffResult::UNSPECIFIED && OS.has_colors()) {
setColor(OS, C); setColor(OS, C);
OS << FormattedItem; OS << FormattedItem;
OS.resetColor(); OS.resetColor();
} else } else
OS << FormattedItem; OS << FormattedItem;
if (Style == AlignStyle::Right) if (Style == AlignStyle::Right)
OS << ' '; OS << ' ';
OS << '|'; OS << '|';
} }