This is an archive of the discontinued LLVM Phabricator instance.

[Polly] [PPCGCodegen] [Crash] [WIP] PPCG + invariant load hoisting
AbandonedPublic

Authored by bollu on Jul 6 2017, 8:34 AM.

Details

Summary
  • Can cause a crash.
  • Discovered this when trying to compile COSMO.
  • Need -polly-codegen-ppcg with -polly-invariant-load-hoisting.

Event Timeline

bollu created this revision.Jul 6 2017, 8:34 AM
grosser requested changes to this revision.Jul 14 2017, 12:39 AM

This is incomplete. I mark it as requesting changes to make sure this does not appear as "to-be-reviewed" in my task list.

This revision now requires changes to proceed.Jul 14 2017, 12:39 AM
bollu added a comment.Jul 18 2017, 8:23 AM

I can no longer reproduce this on HEAD. I'll bisect and see what caused the change.

 [PPCGCodeGeneration] Generate invariant loads before trying to generate IR.

 - We should call `preloadInvariantLoads` to make sure that code is
   generated for invariant loads in the kernel.

Differential Revision: https://reviews.llvm.org/D35410

git-svn-id: https://llvm.org/svn/llvm-project/polly/trunk@308187
bollu abandoned this revision.Jul 24 2017, 5:48 AM

as @grosser pointed out, this is fixed by r308187. Thanks!