Index: lib/CodeGen/SelectionDAG/DAGCombiner.cpp =================================================================== --- lib/CodeGen/SelectionDAG/DAGCombiner.cpp +++ lib/CodeGen/SelectionDAG/DAGCombiner.cpp @@ -8359,7 +8359,7 @@ // Fold truncate of a bitcast of a vector to an extract of the low vector // element. // - // e.g. trunc (i64 (bitcast v2i32:x)) -> extract_vector_elt v2i32:x, 0 + // e.g. trunc (i64 (bitcast v2i32:x)) -> extract_vector_elt v2i32:x, idx if (N0.getOpcode() == ISD::BITCAST && !VT.isVector()) { SDValue VecSrc = N0.getOperand(0); EVT SrcVT = VecSrc.getValueType(); @@ -8369,8 +8369,9 @@ SDLoc SL(N); EVT IdxVT = TLI.getVectorIdxTy(DAG.getDataLayout()); + unsigned Idx = isLE ? 0 : SrcVT.getVectorNumElements() - 1; return DAG.getNode(ISD::EXTRACT_VECTOR_ELT, SL, VT, - VecSrc, DAG.getConstant(0, SL, IdxVT)); + VecSrc, DAG.getConstant(Idx, SL, IdxVT)); } } @@ -13625,9 +13626,11 @@ // converts. } - // extract_vector_elt (v2i32 (bitcast i64:x)), 0 -> i32 (trunc i64:x) + // extract_vector_elt (v2i32 (bitcast i64:x)), EltTrunc -> i32 (trunc i64:x) + bool isLE = DAG.getDataLayout().isLittleEndian(); + unsigned EltTrunc = isLE ? 0 : VT.getVectorNumElements() - 1; if (ConstEltNo && InVec.getOpcode() == ISD::BITCAST && InVec.hasOneUse() && - ConstEltNo->isNullValue() && VT.isInteger()) { + ConstEltNo->getZExtValue() == EltTrunc && VT.isInteger()) { SDValue BCSrc = InVec.getOperand(0); if (BCSrc.getValueType().isScalarInteger()) return DAG.getNode(ISD::TRUNCATE, SDLoc(N), NVT, BCSrc); Index: test/CodeGen/Mips/pr33682.ll =================================================================== --- /dev/null +++ test/CodeGen/Mips/pr33682.ll @@ -0,0 +1,55 @@ +; RUN: llc -march=mips -mcpu=mips32 < %s | FileCheck %s --check-prefixes=ALL,BE +; RUN: llc -march=mipsel -mcpu=mips32 < %s | FileCheck %s --check-prefixes=ALL,LE + +; Verify visitTRUNCATE respects endianness when transforming trunc to insert_vector_elt. + +; ALL-LABEL: a: +; BE: lw $2, 4($4) +; LE: lw $2, 0($4) + +define i32 @a(<2 x i32> * %a) { +entry: +%0 = load <2 x i32>, <2 x i32> * %a +%1 = bitcast <2 x i32> %0 to i64 +%2 = trunc i64 %1 to i32 +ret i32 %2 +} + +; ALL-LABEL: b: +; BE: lw $2, 12($4) +; LE: lw $2, 0($4) + +define i32 @b(<4 x i32> * %a) { +entry: +%0 = load <4 x i32>, <4 x i32> * %a +%1 = bitcast <4 x i32> %0 to i128 +%2 = trunc i128 %1 to i32 +ret i32 %2 +} + + +; Verify visitEXTRACT_VECTOR_ELT respects endianness when transforming extract_vector_elt to a trunc. + +; ALL-LABEL: c: +; BE: lw $2, 0($4) +; LE: lw $2, 0($4) + +define i32 @c(i64 * %a) { +entry: +%0 = load i64, i64 * %a +%1 = bitcast i64 %0 to <2 x i32> +%2 = extractelement <2 x i32> %1, i32 0 +ret i32 %2 +} + +; ALL-LABEL: d: +; BE: lw $2, 4($4) +; LE: lw $2, 4($4) + +define i32 @d(i64 * %a) { +entry: +%0 = load i64, i64 * %a +%1 = bitcast i64 %0 to <2 x i32> +%2 = extractelement <2 x i32> %1, i32 1 +ret i32 %2 +}