This is an archive of the discontinued LLVM Phabricator instance.

Paths

[Bash-completion] Fixed a bug that ~ doesn't expanded to $HOME
ClosedPublic

Authored by yamaguchi on Jul 1 2017, 5:18 AM.

Reviewers

Commits

Summary

~/build/bin/clang -f[tab] was executed without ~ expanded to $HOME, so changed this by expanding ~ to path using eval.

That fixes my issue. LGTM.

This revision is now accepted and ready to land.Jul 1 2017, 8:54 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

cfe/

trunk/

utils/

4 lines

Show All 18 Lines	_clang()
elif [[ "$w1" == -* ]]; then		elif [[ "$w1" == -* ]]; then
# -foo <tab> or -foo bar<tab>		# -foo <tab> or -foo bar<tab>
arg="$w1,$cur"		arg="$w1,$cur"
elif [[ "$w2" == -* && "$w1" == '=' ]]; then		elif [[ "$w2" == -* && "$w1" == '=' ]]; then
# -foo=bar<tab>		# -foo=bar<tab>
arg="$w2=,$cur"		arg="$w2=,$cur"
fi		fi

flags=$( "${COMP_WORDS[0]}" --autocomplete="$arg" 2>/dev/null )		# expand ~ to $HOME
		eval local path=${COMP_WORDS[0]}
		flags=$( "$path" --autocomplete="$arg" 2>/dev/null )
# If clang is old that it does not support --autocomplete,		# If clang is old that it does not support --autocomplete,
# fall back to the filename completion.		# fall back to the filename completion.
if [[ "$?" != 0 ]]; then		if [[ "$?" != 0 ]]; then
_filedir		_filedir
return		return
fi		fi

if [[ "$cur" == '=' ]]; then		if [[ "$cur" == '=' ]]; then
Show All 11 Lines