Page MenuHomePhabricator

[COFF, ARM64] Add support for Windows ARM64 COFF format
ClosedPublic

Authored by mgrang on Jun 27 2017, 1:30 PM.

Event Timeline

mgrang created this revision.Jun 27 2017, 1:30 PM

Here is the llvm part of this patch: https://reviews.llvm.org/D34705

compnerd accepted this revision.Jun 27 2017, 1:35 PM
This revision is now accepted and ready to land.Jun 27 2017, 1:35 PM
ruiu added inline comments.Jun 27 2017, 1:46 PM
lib/Basic/Targets.cpp
6553 ↗(On Diff #104308)

I cannot imagine there will be MicrosoftARM64beTargetInfo, so I wonder if we should name this MicrosoftARM64TargetInfo.

mgrang updated this revision to Diff 104308.Jun 27 2017, 4:24 PM

Comments addressed.

ruiu accepted this revision.Jun 27 2017, 4:32 PM

LGTM. I don't think I have enough knowledge to sign off, but as Saleem has already LGTM'ed, I guess it should be okay.

This revision was automatically updated to reflect the committed changes.