DISCUSS investigate multiline <>-message fields in proto options

[krasimir]

Summary

This shows that we don't currently support multiline brace message fields
in proto options yet.

This currently gets formatted (with colum limit 60) into:

option (MyProto.options) = {
  msg_field: <
    field_a: OK field_b: OK field_c: OK field_d: OK
    field_e: OK
    field_f: OK >
}

[djasper]

So, what do you want to discuss? The problem is (I think) that we treat a colon as "this can't be a template" in TokenAnnotator::parseAngle. We probably shouldn't do that for proto text.

[krasimir]

do we wanna keep the '<' classify as a template opener or as a dict literal?

[djasper]

I am not really sure. Dict literals seems cleaner, but it might confuse us in other places.

unittests/Format/FormatTestProto.cpp

TEST_F(FormatTestProto, FormatsImports) {
   // Missing semicolons should not confuse clang-format.
   verifyFormat("import \"a.proto\"\n"
                "import \"b.proto\"\n"
                "// comment\n"
                "message A {\n"
                "}");
 }
 
+TEST_F(FormatTestProto, TODO) {
+  verifyFormat("option (MyProto.options) = {\n"
+               "  msg_field: <\n"
+               "    field_a: OK\n"
+               "    field_b: OK\n"
+               "    field_c: OK\n"
+               "    field_d: OK\n"
+               "    field_e: OK\n"
+               "    field_f: OK\n"
+               "  >\n"
+               "};");
+}
+
 } // end namespace tooling
 } // end namespace clang