Index: cfe/trunk/lib/CodeGen/CGDecl.cpp =================================================================== --- cfe/trunk/lib/CodeGen/CGDecl.cpp +++ cfe/trunk/lib/CodeGen/CGDecl.cpp @@ -162,6 +162,10 @@ // needs to be emitted like a static variable, e.g. a function-scope // variable in constant address space in OpenCL. if (D.getStorageDuration() != SD_Automatic) { + // Static sampler variables translated to function calls. + if (D.getType()->isSamplerT()) + return; + llvm::GlobalValue::LinkageTypes Linkage = CGM.getLLVMLinkageVarDefinition(&D, /*isConstant=*/false); Index: cfe/trunk/test/CodeGenOpenCL/sampler.cl =================================================================== --- cfe/trunk/test/CodeGenOpenCL/sampler.cl +++ cfe/trunk/test/CodeGenOpenCL/sampler.cl @@ -20,6 +20,8 @@ constant sampler_t glb_smp = CLK_ADDRESS_CLAMP_TO_EDGE | CLK_NORMALIZED_COORDS_TRUE | CLK_FILTER_LINEAR; // CHECK-NOT: glb_smp +int get_sampler_initializer(void); + void fnc4smp(sampler_t s) {} // CHECK: define spir_func void @fnc4smp(%opencl.sampler_t addrspace(2)* % @@ -58,4 +60,20 @@ fnc4smp(5); // CHECK: [[SAMP:%[0-9]+]] = call %opencl.sampler_t addrspace(2)* @__translate_sampler_initializer(i32 5) // CHECK: call spir_func void @fnc4smp(%opencl.sampler_t addrspace(2)* [[SAMP]]) + + const sampler_t const_smp = CLK_ADDRESS_CLAMP_TO_EDGE | CLK_NORMALIZED_COORDS_TRUE | CLK_FILTER_LINEAR; + fnc4smp(const_smp); + // CHECK: [[CONST_SAMP:%[0-9]+]] = call %opencl.sampler_t addrspace(2)* @__translate_sampler_initializer(i32 35) + // CHECK: store %opencl.sampler_t addrspace(2)* [[CONST_SAMP]], %opencl.sampler_t addrspace(2)** [[CONST_SMP_PTR:%[a-zA-Z0-9]+]] + fnc4smp(const_smp); + // CHECK: [[SAMP:%[0-9]+]] = load %opencl.sampler_t addrspace(2)*, %opencl.sampler_t addrspace(2)** [[CONST_SMP_PTR]] + // CHECK: call spir_func void @fnc4smp(%opencl.sampler_t addrspace(2)* [[SAMP]]) + + constant sampler_t constant_smp = CLK_ADDRESS_CLAMP_TO_EDGE | CLK_NORMALIZED_COORDS_TRUE | CLK_FILTER_LINEAR; + fnc4smp(constant_smp); + // CHECK: [[SAMP:%[0-9]+]] = call %opencl.sampler_t addrspace(2)* @__translate_sampler_initializer(i32 35) + // CHECK: call spir_func void @fnc4smp(%opencl.sampler_t addrspace(2)* [[SAMP]]) + + // TODO: enable sampler initialization with non-constant integer. + //const sampler_t const_smp_func_init = get_sampler_initializer(); } Index: cfe/trunk/test/SemaOpenCL/sampler_t.cl =================================================================== --- cfe/trunk/test/SemaOpenCL/sampler_t.cl +++ cfe/trunk/test/SemaOpenCL/sampler_t.cl @@ -46,36 +46,11 @@ void kernel ker(sampler_t argsmp) { local sampler_t smp; // expected-error{{sampler type cannot be used with the __local and __global address space qualifiers}} - const sampler_t const_smp = CLK_ADDRESS_CLAMP_TO_EDGE | CLK_NORMALIZED_COORDS_TRUE | CLK_FILTER_LINEAR; - const sampler_t const_smp2; - const sampler_t const_smp3 = const_smp; - const sampler_t const_smp4 = f(); const sampler_t const_smp5 = 1.0f; // expected-error{{initializing 'const sampler_t' with an expression of incompatible type 'float'}} const sampler_t const_smp6 = 0x100000000LL; // expected-error{{sampler_t initialization requires 32-bit integer, not 'long long'}} - foo(glb_smp); - foo(glb_smp2); - foo(glb_smp3); - foo(glb_smp4); - foo(glb_smp5); - foo(glb_smp6); - foo(glb_smp7); - foo(glb_smp8); - foo(glb_smp9); - foo(smp); - foo(sampler_str.smp); - foo(const_smp); - foo(const_smp2); - foo(const_smp3); - foo(const_smp4); - foo(const_smp5); - foo(const_smp6); - foo(argsmp); - foo(5); foo(5.0f); // expected-error {{passing 'float' to parameter of incompatible type 'sampler_t'}} - sampler_t sa[] = {argsmp, const_smp}; // expected-error {{array of 'sampler_t' type is invalid in OpenCL}} - foo(sa[0]); - foo(bad()); + sampler_t sa[] = {argsmp, glb_smp}; // expected-error {{array of 'sampler_t' type is invalid in OpenCL}} } void bad(sampler_t*); // expected-error{{pointer to type 'sampler_t' is invalid in OpenCL}}