Page MenuHomePhabricator

[clangd] Add priority to completion item sort text
ClosedPublic

Authored by krasimir on Jun 13 2017, 2:00 AM.

Event Timeline

krasimir created this revision.Jun 13 2017, 2:00 AM
krasimir added a project: Restricted Project.Jun 13 2017, 2:02 AM
krasimir added a subscriber: cfe-commits.
ilya-biryukov added inline comments.Jun 14 2017, 2:46 AM
clangd/ClangdUnit.cpp
156 ↗(On Diff #102522)

This is a no-op, commited incidentally?

162 ↗(On Diff #102522)

Maybe add an assert(CCS.getPriority() < 99999)?

krasimir updated this revision to Diff 102522.Jun 14 2017, 4:10 AM
  • Address review comments
krasimir marked 2 inline comments as done.Jun 14 2017, 4:10 AM
ilya-biryukov accepted this revision.Jun 14 2017, 5:49 AM
This revision is now accepted and ready to land.Jun 14 2017, 5:49 AM
This revision was automatically updated to reflect the committed changes.