This is an archive of the discontinued LLVM Phabricator instance.

Fortran support
Needs RevisionPublic

Authored by junghans on Jun 11 2017, 7:00 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

junghans created this revision.Jun 11 2017, 7:00 PM

Some source files are turned into executables.

I have mixed feeling about hardcoding of one Linux distro specific paths.

lib/Driver/ToolChain.cpp
702

Why this?

lib/Driver/ToolChains.cpp
4479

Why to hardcode /usr/local/include?

junghans accepted this revision.Jun 14 2017, 11:54 AM
junghans added inline comments.
lib/Driver/ToolChain.cpp
702

Yes, that should be dropped.

lib/Driver/ToolChains.cpp
4479

That should be dropped as well.

This revision is now accepted and ready to land.Jun 14 2017, 11:54 AM
junghans updated this revision to Diff 102589.Jun 14 2017, 11:56 AM

Included suggestions by @krytarowski .

hfinkel requested changes to this revision.Jun 28 2017, 9:29 AM
hfinkel added a subscriber: hfinkel.

To note: Our current plan is that, after the PGI folks send announcements to the llvm-dev list discussing the state of the project in general, we'll write an RFC for cfe-dev to discuss the possibility of merging in the driver support.

This revision now requires changes to proceed.Jun 28 2017, 9:29 AM
junghans resigned from this revision.Jun 28 2017, 9:33 AM

Ok, Hal, can you take it from here?

Ok, Hal, can you take it from here?

Yes.

The patch also breaks a couple of tests (see attachment from fedora build)