Index: test/tools/obj2yaml/invalid_input_file.test =================================================================== --- /dev/null +++ test/tools/obj2yaml/invalid_input_file.test @@ -0,0 +1,4 @@ +# RUN: not obj2yaml %p/path/does/not/exist 2>&1 | FileCheck %s + +# Don't check the OS-dependent message "No such file or directory". +# CHECK: Error reading file: {{.*}}/path/does/not/exist: {{.*}} Index: tools/obj2yaml/obj2yaml.cpp =================================================================== --- tools/obj2yaml/obj2yaml.cpp +++ tools/obj2yaml/obj2yaml.cpp @@ -30,21 +30,32 @@ return obj2yaml_error::unsupported_obj_file_format; } -static std::error_code dumpInput(StringRef File) { +static Error dumpInput(StringRef File) { Expected> BinaryOrErr = createBinary(File); if (!BinaryOrErr) - return errorToErrorCode(BinaryOrErr.takeError()); + return BinaryOrErr.takeError(); Binary &Binary = *BinaryOrErr.get().getBinary(); // Universal MachO is not a subclass of ObjectFile, so it needs to be handled // here with the other binary types. if (Binary.isMachO() || Binary.isMachOUniversalBinary()) - return macho2yaml(outs(), Binary); + return errorCodeToError(macho2yaml(outs(), Binary)); // TODO: If this is an archive, then burst it and dump each entry if (ObjectFile *Obj = dyn_cast(&Binary)) - return dumpObject(*Obj); + return errorCodeToError(dumpObject(*Obj)); - return obj2yaml_error::unrecognized_file_format; + return Error::success(); +} + +static void reportError(StringRef Input, Error Err) { + if (Input == "-") + Input = ""; + std::string ErrMsg; + raw_string_ostream OS(ErrMsg); + logAllUnhandledErrors(std::move(Err), OS, ""); + OS.flush(); + errs() << "Error reading file: " << Input << ": " << ErrMsg; + errs().flush(); } cl::opt InputFilename(cl::Positional, cl::desc(""), @@ -56,8 +67,8 @@ PrettyStackTraceProgram X(argc, argv); llvm_shutdown_obj Y; // Call llvm_shutdown() on exit. - if (std::error_code EC = dumpInput(InputFilename)) { - errs() << "Error: '" << EC.message() << "'\n"; + if (Error Err = dumpInput(InputFilename)) { + reportError(InputFilename, std::move(Err)); return 1; }