This is an archive of the discontinued LLVM Phabricator instance.

__cxa_demangle: Fix constructor cv qualifier handling
ClosedPublic

Authored by tberghammer on May 21 2017, 7:34 AM.

Details

Summary

Previously if we parsed a constructor then we set parsed_ctor_dtor_cv
to true and never reseted it. This causes issue when a template argument
references a constructor (e.g. type of lambda defined inside a
constructor) as we will have the parsed_ctor_dtor_cv flag set what will
cause issues when parsing later arguments.

Diff Detail

Repository
rL LLVM

Event Timeline

tberghammer created this revision.May 21 2017, 7:34 AM
compnerd accepted this revision.May 21 2017, 8:06 PM
This revision is now accepted and ready to land.May 21 2017, 8:06 PM

Can you please ensure that you cross-port this into llvm/lib/Demangle/ItaniumDemangle.cpp?

This revision was automatically updated to reflect the committed changes.