Index: include/clang/AST/CXXInheritance.h =================================================================== --- include/clang/AST/CXXInheritance.h +++ include/clang/AST/CXXInheritance.h @@ -127,7 +127,11 @@ /// class subobjects for that class type. The key of the map is /// the cv-unqualified canonical type of the base class subobject. llvm::SmallDenseMap, 8> ClassSubobjects; - + + /// VisitedDependentRecords - Records the dependent records that have been + /// already visited. + llvm::SmallDenseSet VisitedDependentRecords; + /// FindAmbiguities - Whether Sema::IsDerivedFrom should try find /// ambiguous paths while it is looking for a path from a derived /// type to a base type. Index: lib/AST/CXXInheritance.cpp =================================================================== --- lib/AST/CXXInheritance.cpp +++ lib/AST/CXXInheritance.cpp @@ -57,6 +57,7 @@ void CXXBasePaths::clear() { Paths.clear(); ClassSubobjects.clear(); + VisitedDependentRecords.clear(); ScratchPath.clear(); DetectedVirtual = nullptr; } @@ -67,6 +68,7 @@ std::swap(Origin, Other.Origin); Paths.swap(Other.Paths); ClassSubobjects.swap(Other.ClassSubobjects); + VisitedDependentRecords.swap(Other.VisitedDependentRecords); std::swap(FindAmbiguities, Other.FindAmbiguities); std::swap(RecordPaths, Other.RecordPaths); std::swap(DetectVirtual, Other.DetectVirtual); @@ -278,8 +280,14 @@ dyn_cast_or_null(TN.getAsTemplateDecl())) BaseRecord = TD->getTemplatedDecl(); } - if (BaseRecord && !BaseRecord->hasDefinition()) - BaseRecord = nullptr; + if (BaseRecord) { + if (!BaseRecord->hasDefinition()) + BaseRecord = nullptr; + else if (VisitedDependentRecords.count(BaseRecord)) + BaseRecord = nullptr; + else + VisitedDependentRecords.insert(BaseRecord); + } } else { BaseRecord = cast( BaseSpec.getType()->castAs()->getDecl()); Index: test/Index/Core/index-dependent-source.cpp =================================================================== --- test/Index/Core/index-dependent-source.cpp +++ test/Index/Core/index-dependent-source.cpp @@ -141,3 +141,20 @@ x.lookup; typename UserOfUndefinedTemplateClass::Type y; } + +template struct Dropper; + +template struct Trait; + +template +struct Recurse : Trait::Type> { }; + +template +struct Trait : Recurse { +}; + +template +void infiniteTraitRecursion(Trait &t) { +// Shouldn't crash! + t.lookup; +}