Page MenuHomePhabricator

[scan-build] Patch to scan-build tool to support "--target=<value>" flag
ClosedPublic

Authored by haowei on May 16 2017, 3:48 PM.

Details

Summary

The scan-build script provided by clang can be used to detect defects in code in the compile time. However, we discovered that the "--target=<value>" flag in clang is not properly handled by this script, which results in failures when analyzing projects that have used this flag in their makefile.

This single line of change allows scan-build script to properly handle the "--target=<value>" flag

Event Timeline

haowei created this revision.May 16 2017, 3:48 PM
zaks.anna accepted this revision.May 16 2017, 5:21 PM

Looks good. Thank you!
Do you have commit access or should we commit?

This revision is now accepted and ready to land.May 16 2017, 5:21 PM

Looks good. Thank you!
Do you have commit access or should we commit?

I don't have commit access, so could you commit this patch?

Thanks.

This revision was automatically updated to reflect the committed changes.