Index: llvm/trunk/lib/Transforms/Utils/VNCoercion.cpp =================================================================== --- llvm/trunk/lib/Transforms/Utils/VNCoercion.cpp +++ llvm/trunk/lib/Transforms/Utils/VNCoercion.cpp @@ -24,6 +24,11 @@ if (DL.getTypeSizeInBits(StoredVal->getType()) < DL.getTypeSizeInBits(LoadTy)) return false; + // Don't coerce non-integral pointers to integers or vice versa. + if (DL.isNonIntegralPointerType(StoredVal->getType()) != + DL.isNonIntegralPointerType(LoadTy)) + return false; + return true; } Index: llvm/trunk/test/Transforms/GVN/non-integral-pointers.ll =================================================================== --- llvm/trunk/test/Transforms/GVN/non-integral-pointers.ll +++ llvm/trunk/test/Transforms/GVN/non-integral-pointers.ll @@ -0,0 +1,39 @@ +; RUN: opt -gvn -S < %s | FileCheck %s + +target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128-ni:4" +target triple = "x86_64-unknown-linux-gnu" + +define void @f0(i1 %alwaysFalse, i64 %val, i64* %loc) { +; CHECK-LABEL: @f0( +; CHECK-NOT: inttoptr +; CHECK-NOT: ptrtoint + entry: + store i64 %val, i64* %loc + br i1 %alwaysFalse, label %neverTaken, label %alwaysTaken + + neverTaken: + %loc.bc = bitcast i64* %loc to i8 addrspace(4)** + %ptr = load i8 addrspace(4)*, i8 addrspace(4)** %loc.bc + store i8 5, i8 addrspace(4)* %ptr + ret void + + alwaysTaken: + ret void +} + +define i64 @f1(i1 %alwaysFalse, i8 addrspace(4)* %val, i8 addrspace(4)** %loc) { +; CHECK-LABEL: @f1( +; CHECK-NOT: inttoptr +; CHECK-NOT: ptrtoint + entry: + store i8 addrspace(4)* %val, i8 addrspace(4)** %loc + br i1 %alwaysFalse, label %neverTaken, label %alwaysTaken + + neverTaken: + %loc.bc = bitcast i8 addrspace(4)** %loc to i64* + %int = load i64, i64* %loc.bc + ret i64 %int + + alwaysTaken: + ret i64 42 +} Index: llvm/trunk/test/Transforms/NewGVN/non-integral-pointers.ll =================================================================== --- llvm/trunk/test/Transforms/NewGVN/non-integral-pointers.ll +++ llvm/trunk/test/Transforms/NewGVN/non-integral-pointers.ll @@ -0,0 +1,39 @@ +; RUN: opt -newgvn -S < %s | FileCheck %s + +target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128-ni:4" +target triple = "x86_64-unknown-linux-gnu" + +define void @f0(i1 %alwaysFalse, i64 %val, i64* %loc) { +; CHECK-LABEL: @f0( +; CHECK-NOT: inttoptr +; CHECK-NOT: ptrtoint + entry: + store i64 %val, i64* %loc + br i1 %alwaysFalse, label %neverTaken, label %alwaysTaken + + neverTaken: + %loc.bc = bitcast i64* %loc to i8 addrspace(4)** + %ptr = load i8 addrspace(4)*, i8 addrspace(4)** %loc.bc + store i8 5, i8 addrspace(4)* %ptr + ret void + + alwaysTaken: + ret void +} + +define i64 @f1(i1 %alwaysFalse, i8 addrspace(4)* %val, i8 addrspace(4)** %loc) { +; CHECK-LABEL: @f1( +; CHECK-NOT: inttoptr +; CHECK-NOT: ptrtoint + entry: + store i8 addrspace(4)* %val, i8 addrspace(4)** %loc + br i1 %alwaysFalse, label %neverTaken, label %alwaysTaken + + neverTaken: + %loc.bc = bitcast i8 addrspace(4)** %loc to i64* + %int = load i64, i64* %loc.bc + ret i64 %int + + alwaysTaken: + ret i64 42 +}