Index: include/clang/AST/Decl.h =================================================================== --- include/clang/AST/Decl.h +++ include/clang/AST/Decl.h @@ -2082,10 +2082,9 @@ const Attr *getUnusedResultAttr() const; /// \brief Returns true if this function or its return type has the - /// warn_unused_result attribute. If the return type has the attribute and - /// this function is a method of the return type's class, then false will be - /// returned to avoid spurious warnings on member methods such as assignment - /// operators. + /// warn_unused_result attribute. If the return type has the attribute, + /// and this function is a post-increment operator, then false will be returned + /// to avoid valid, albeit ubiquitous warnings. bool hasUnusedResultAttr() const { return getUnusedResultAttr() != nullptr; } /// \brief Returns the storage class as written in the source. For the Index: lib/AST/Decl.cpp =================================================================== --- lib/AST/Decl.cpp +++ lib/AST/Decl.cpp @@ -3004,8 +3004,11 @@ QualType RetType = getReturnType(); if (RetType->isRecordType()) { const CXXRecordDecl *Ret = RetType->getAsCXXRecordDecl(); - const auto *MD = dyn_cast(this); - if (Ret && !(MD && MD->getCorrespondingMethodInClass(Ret, true))) { + auto OpCode = getOverloadedOperator(); + bool IsPostfix = + (OpCode == OO_PlusPlus || OpCode == OO_MinusMinus) && + (this->getNumParams() + (isa(this) ? 1 : 0)) == 2; + if (Ret && !IsPostfix) { if (const auto *R = Ret->getAttr()) return R; } Index: test/SemaCXX/warn-unused-result.cpp =================================================================== --- test/SemaCXX/warn-unused-result.cpp +++ test/SemaCXX/warn-unused-result.cpp @@ -160,3 +160,41 @@ (void)noexcept(f(), false); // Should not warn. } } +namespace { +// C++ Methods should warn even in their own class. Post increment/decrement +// are special-cased to not warn for return-type due to ubiquitousness. +struct[[clang::warn_unused_result]] S { + S DoThing() { return {}; }; + S operator++(int) { return {}; }; + S operator--(int) { return {}; }; + S operator++() { return {}; }; + S operator--() { return {}; }; +}; + +struct[[clang::warn_unused_result]] P { + P DoThing() { return {}; }; +}; + +P operator++(const P &, int) { return {}; }; +P operator++(const P &) { return {}; }; +P operator--(const P &, int) { return {}; }; +P operator--(const P &) { return {}; }; + +void f() { + S s; + P p; + s.DoThing(); // expected-warning {{ignoring return value}} + p.DoThing(); // expected-warning {{ignoring return value}} + // Special case the following to not warn. + s++; + s--; + p++; + p--; + // Improperly written prefix operators should still warn. + ++s; // expected-warning {{ignoring return value}} + --s; // expected-warning {{ignoring return value}} + ++p; // expected-warning {{ignoring return value}} + --p; // expected-warning {{ignoring return value}} + +} +}