Index: llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp =================================================================== --- llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp +++ llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp @@ -3536,6 +3536,10 @@ // If the load type was an EXTLOAD, convert to ZEXTLOAD in order to // preserve semantics once we get rid of the AND. SDValue NewLoad(Load, 0); + + // Fold the AND away. NewLoad may get replaced immediately. + CombineTo(N, NewLoad); + if (Load->getExtensionType() == ISD::EXTLOAD) { NewLoad = DAG.getLoad(Load->getAddressingMode(), ISD::ZEXTLOAD, Load->getValueType(0), SDLoc(Load), @@ -3553,10 +3557,6 @@ } } - // Fold the AND away, taking care not to fold to the old load node if we - // replaced it. - CombineTo(N, (N0.getNode() == Load) ? NewLoad : N0); - return SDValue(N, 0); // Return N so it doesn't get rechecked! } } Index: llvm/trunk/test/CodeGen/SystemZ/pr32372.ll =================================================================== --- llvm/trunk/test/CodeGen/SystemZ/pr32372.ll +++ llvm/trunk/test/CodeGen/SystemZ/pr32372.ll @@ -0,0 +1,31 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc %s -o - -mtriple=s390x-linux-gnu | FileCheck %s + +define void @pr32372(i8*) { +; CHECK-LABEL: pr32372: +; CHECK: # BB#0: # %BB +; CHECK-NEXT: llc %r1, 0(%r2) +; CHECK-NEXT: mvhhi 0(%r1), -3825 +; CHECK-NEXT: llill %r0, 0 +; CHECK-NEXT: dlr %r0, %r1 +; CHECK-NEXT: .LBB0_1: # %CF251 +; CHECK-NEXT: # =>This Inner Loop Header: Depth=1 +; CHECK-NEXT: j .LBB0_1 +BB: + %L = load i8, i8* %0 + store i16 -3825, i16* undef + %L5 = load i8, i8* %0 + %B9 = urem i8 %L5, %L + %I107 = insertelement <8 x i8> zeroinitializer, i8 %B9, i32 7 + %ZE141 = zext i8 %L5 to i16 + br label %CF251 + +CF251: ; preds = %CF258, %CF251, %BB + %Shuff217 = shufflevector <8 x i8> zeroinitializer, <8 x i8> %I107, <8 x i32> + %Cmp227 = icmp sge i16 %ZE141, 0 + br i1 %Cmp227, label %CF251, label %CF258 + +CF258: ; preds = %CF251 + %Shuff230 = shufflevector <2 x i16> undef, <2 x i16> undef, <2 x i32> + br label %CF251 +}