Index: lib/Format/Format.cpp =================================================================== --- lib/Format/Format.cpp +++ lib/Format/Format.cpp @@ -766,13 +766,29 @@ return false; } - bool parseParens() { + bool parseParens(bool LookForDecls = false) { if (CurrentToken == NULL) return false; AnnotatedToken *Left = CurrentToken->Parent; if (CurrentToken->is(tok::caret)) Left->Type = TT_ObjCBlockLParen; while (CurrentToken != NULL) { + // LookForDecls is set when "if (" has been seen. Check for + // 'identifier' '*' 'identifier' followed by not '=' -- this + // '*' has to be a binary operator but determineStarAmpUsage() will + // categorize it as an unary operator, so set the right type here. + // Look for "if (identifier + if (LookForDecls && !CurrentToken->Children.empty()) { + AnnotatedToken &Prev = *CurrentToken->Parent; + AnnotatedToken &Next = CurrentToken->Children[0]; + if (Prev.Parent->is(tok::identifier) && + (Prev.is(tok::star) || Prev.is(tok::amp)) && + CurrentToken->is(tok::identifier) && Next.isNot(tok::equal)) { + Prev.Type = TT_BinaryOperator; + LookForDecls = false; + } + } + if (CurrentToken->is(tok::r_paren)) { Left->MatchingParen = CurrentToken; CurrentToken->MatchingParen = Left; @@ -891,6 +907,14 @@ if (ColonIsObjCMethodExpr) Tok->Type = TT_ObjCMethodExpr; break; + case tok::kw_if: + case tok::kw_while: + if (CurrentToken->is(tok::l_paren)) { + next(); + if (!parseParens(/*LookForDecls=*/true)) + return false; + } + break; case tok::l_paren: { bool ParensWereObjCReturnType = Tok->Parent && Tok->Parent->Type == TT_ObjCMethodSpecifier; Index: unittests/Format/FormatTest.cpp =================================================================== --- unittests/Format/FormatTest.cpp +++ unittests/Format/FormatTest.cpp @@ -1193,6 +1193,14 @@ " *A, // Operator detection might be confused by the '{'\n" " *BB // Operator detection might be confused by previous comment\n" "};"); + + verifyFormat("if (int *a = &b)"); + verifyFormat("if (int &a = *b)"); + verifyFormat("if (a & b[i])"); + verifyFormat("if (a::b::c::d & b[i])"); + verifyFormat("if (*b[i])"); + verifyFormat("if (int *a = (&b))"); + verifyFormat("while (int *a = &b)"); } TEST_F(FormatTest, FormatsCasts) {