Index: llvm/trunk/include/llvm/Support/FormatProviders.h =================================================================== --- llvm/trunk/include/llvm/Support/FormatProviders.h +++ llvm/trunk/include/llvm/Support/FormatProviders.h @@ -45,9 +45,8 @@ template struct use_string_formatter - : public std::integral_constant< - bool, is_one_of::value || - is_cstring::value> {}; + : public std::integral_constant::value> {}; template struct use_pointer_formatter @@ -205,7 +204,7 @@ if (!Style.empty() && Style.getAsInteger(10, N)) { assert(false && "Style is not a valid integer"); } - llvm::StringRef S(V); + llvm::StringRef S = V; Stream << S.substr(0, N); } }; Index: llvm/trunk/unittests/Support/FormatVariadicTest.cpp =================================================================== --- llvm/trunk/unittests/Support/FormatVariadicTest.cpp +++ llvm/trunk/unittests/Support/FormatVariadicTest.cpp @@ -324,11 +324,13 @@ const char FooArray[] = "FooArray"; const char *FooPtr = "FooPtr"; llvm::StringRef FooRef("FooRef"); + constexpr StringLiteral FooLiteral("FooLiteral"); std::string FooString("FooString"); // 1. Test that we can print various types of strings. EXPECT_EQ(FooArray, formatv("{0}", FooArray).str()); EXPECT_EQ(FooPtr, formatv("{0}", FooPtr).str()); EXPECT_EQ(FooRef, formatv("{0}", FooRef).str()); + EXPECT_EQ(FooLiteral, formatv("{0}", FooLiteral).str()); EXPECT_EQ(FooString, formatv("{0}", FooString).str()); // 2. Test that the precision specifier prints the correct number of