Index: lib/Transforms/InstCombine/InstCombineAddSub.cpp =================================================================== --- lib/Transforms/InstCombine/InstCombineAddSub.cpp +++ lib/Transforms/InstCombine/InstCombineAddSub.cpp @@ -1044,9 +1044,16 @@ const APInt *Val; if (match(RHS, m_APInt(Val))) { - // X + (signbit) --> X ^ signbit - if (Val->isSignBit()) + if (Val->isSignBit()) { + // If wrapping is not allowed, then the addition must set the sign bit: + // X + (signbit) --> X | signbit + if (I.hasNoSignedWrap() || I.hasNoUnsignedWrap()) + return BinaryOperator::CreateOr(LHS, RHS); + + // If wrapping is allowed, then the addition flips the sign bit of LHS: + // X + (signbit) --> X ^ signbit return BinaryOperator::CreateXor(LHS, RHS); + } // Is this add the last step in a convoluted sext? Value *X; Index: test/Transforms/InstCombine/add.ll =================================================================== --- test/Transforms/InstCombine/add.ll +++ test/Transforms/InstCombine/add.ll @@ -244,11 +244,13 @@ ret i32 %V } -; Add of sign bit -> xor of sign bit. +; With NSW, add of sign bit -> or of sign bit. +; FIXME: This should be 'ret %x' because we know that %x's sign bit must be set already. define i32 @test20(i32 %x) { ; CHECK-LABEL: @test20( -; CHECK-NEXT: ret i32 %x +; CHECK-NEXT: [[Z:%.*]] = or i32 %x, -2147483648 +; CHECK-NEXT: ret i32 [[Z]] ; %y = xor i32 %x, -2147483648 %z = add nsw i32 %y, -2147483648 @@ -265,24 +267,22 @@ ret i32 %add } -; Lose no-wrap info by converting to xor? %x is known non-negative -; here, but not after converting to xor. +; No-wrap info allows converting the add to 'or'. define i8 @add_nsw_signbit(i8 %x) { ; CHECK-LABEL: @add_nsw_signbit( -; CHECK-NEXT: [[Y:%.*]] = xor i8 %x, -128 +; CHECK-NEXT: [[Y:%.*]] = or i8 %x, -128 ; CHECK-NEXT: ret i8 [[Y]] ; %y = add nsw i8 %x, -128 ret i8 %y } -; Lose no-wrap info by converting to xor? %x is known non-negative -; (x < 128 unsigned), but not after converting to xor. +; No-wrap info allows converting the add to 'or'. define i8 @add_nuw_signbit(i8 %x) { ; CHECK-LABEL: @add_nuw_signbit( -; CHECK-NEXT: [[Y:%.*]] = xor i8 %x, -128 +; CHECK-NEXT: [[Y:%.*]] = or i8 %x, -128 ; CHECK-NEXT: ret i8 [[Y]] ; %y = add nuw i8 %x, 128 Index: test/Transforms/InstCombine/icmp-add.ll =================================================================== --- test/Transforms/InstCombine/icmp-add.ll +++ test/Transforms/InstCombine/icmp-add.ll @@ -223,24 +223,22 @@ ret i1 %c } -; FIXME: InstCombine should not lose wrapping information by changing the add to xor. +; InstCombine should not thwart this opportunity to simplify completely. define i1 @slt_zero_add_nsw_signbit(i8 %x) { ; CHECK-LABEL: @slt_zero_add_nsw_signbit( -; CHECK-NEXT: [[Z:%.*]] = icmp sgt i8 %x, -1 -; CHECK-NEXT: ret i1 [[Z]] +; CHECK-NEXT: ret i1 true ; %y = add nsw i8 %x, -128 %z = icmp slt i8 %y, 0 ret i1 %z } -; FIXME: InstCombine should not lose wrapping information by changing the add to xor. +; InstCombine should not thwart this opportunity to simplify completely. define i1 @slt_zero_add_nuw_signbit(i8 %x) { ; CHECK-LABEL: @slt_zero_add_nuw_signbit( -; CHECK-NEXT: [[Z:%.*]] = icmp sgt i8 %x, -1 -; CHECK-NEXT: ret i1 [[Z]] +; CHECK-NEXT: ret i1 true ; %y = add nuw i8 %x, 128 %z = icmp slt i8 %y, 0