Index: include/clang/Basic/Attr.td =================================================================== --- include/clang/Basic/Attr.td +++ include/clang/Basic/Attr.td @@ -1178,6 +1178,13 @@ let Documentation = [AssumeAlignedDocs]; } +def AllocAlign : InheritableAttr { + let Spellings = [ GCC<"alloc_align"> ]; + let Subjects = SubjectList<[Function]>; + let Args = [ IntArgument<"ParamIndex"> ]; + let Documentation = [ AllocAlignDocs ]; +} + def NoReturn : InheritableAttr { let Spellings = [GCC<"noreturn">, Declspec<"noreturn">]; // FIXME: Does GCC allow this on the function instead? Index: include/clang/Basic/AttrDocs.td =================================================================== --- include/clang/Basic/AttrDocs.td +++ include/clang/Basic/AttrDocs.td @@ -244,6 +244,27 @@ }]; } +def AllocAlignDocs : Documentation { + let Category = DocCatFunction; + let Content = [{ +Use ``__attribute__((alloc_align())`` on a function +declaration to specify that the return value of the function (which must be a +pointer type) has an alignment specified by the indicated parameter, starting +with 1. + +.. code-block:: c++ + // The returned pointer has the alignment specified by the first parameter + void *a(size_t align) __attribute__((alloc_align(1))); + + // The returned pointer has the alignment specified by the second parameter + void *b(void* v, size_t align) __attribute__((alloc_align(2))); + +Note that this attribute provides information to the compiler regarding a +condition that the code already ensures is true. It does not cause the compiler +to enforce the provided alignment assumption. + }]; +} + def EnableIfDocs : Documentation { let Category = DocCatFunction; let Content = [{ Index: include/clang/Sema/Sema.h =================================================================== --- include/clang/Sema/Sema.h +++ include/clang/Sema/Sema.h @@ -8125,6 +8125,11 @@ void AddAssumeAlignedAttr(SourceRange AttrRange, Decl *D, Expr *E, Expr *OE, unsigned SpellingListIndex); + /// AddAllocAlignAttr - Adds an alloc_align attribute to a particular + /// declaration. + void AddAllocAlignAttr(SourceRange AttrRange, Decl *D, Expr *ParamExpr, + const AttributeList &Attr, unsigned SpellingListIndex); + /// AddAlignValueAttr - Adds an align_value attribute to a particular /// declaration. void AddAlignValueAttr(SourceRange AttrRange, Decl *D, Expr *E, Index: lib/CodeGen/CGCall.cpp =================================================================== --- lib/CodeGen/CGCall.cpp +++ lib/CodeGen/CGCall.cpp @@ -4225,7 +4225,11 @@ llvm::ConstantInt *AlignmentCI = cast(Alignment); EmitAlignmentAssumption(Ret.getScalarVal(), AlignmentCI->getZExtValue(), OffsetValue); + } else if (const auto *AA = TargetDecl->getAttr()) { + llvm::Value *ParamVal = IRCallArgs[AA->getParamIndex() - 1]; + EmitAlignmentAssumption(Ret.getScalarVal(), ParamVal); } + } return Ret; Index: lib/CodeGen/CodeGenFunction.h =================================================================== --- lib/CodeGen/CodeGenFunction.h +++ lib/CodeGen/CodeGenFunction.h @@ -2412,6 +2412,12 @@ PeepholeProtection protectFromPeepholes(RValue rvalue); void unprotectFromPeepholes(PeepholeProtection protection); + void EmitAlignmentAssumption(llvm::Value *PtrValue, llvm::Value *Alignment, + llvm::Value *OffsetValue = nullptr) { + Builder.CreateAlignmentAssumption(CGM.getDataLayout(), PtrValue, Alignment, + OffsetValue); + } + //===--------------------------------------------------------------------===// // Statement Emission //===--------------------------------------------------------------------===// Index: lib/Sema/SemaDeclAttr.cpp =================================================================== --- lib/Sema/SemaDeclAttr.cpp +++ lib/Sema/SemaDeclAttr.cpp @@ -1484,6 +1484,13 @@ Attr.getAttributeSpellingListIndex()); } +static void handleAllocAlignAttr(Sema &S, Decl *D, + const AttributeList &Attr) { + Expr *E = Attr.getArgAsExpr(0); + S.AddAllocAlignAttr(Attr.getRange(), D, E, Attr, + Attr.getAttributeSpellingListIndex()); +} + void Sema::AddAssumeAlignedAttr(SourceRange AttrRange, Decl *D, Expr *E, Expr *OE, unsigned SpellingListIndex) { QualType ResultType = getFunctionOrMethodResultType(D); @@ -1535,6 +1542,34 @@ AssumeAlignedAttr(AttrRange, Context, E, OE, SpellingListIndex)); } +void Sema::AddAllocAlignAttr(SourceRange AttrRange, Decl *D, Expr *ParamExpr, + const AttributeList &Attr, + unsigned SpellingListIndex) { + QualType ResultType = getFunctionOrMethodResultType(D); + SourceRange SR = getFunctionOrMethodResultSourceRange(D); + + AllocAlignAttr TmpAttr(AttrRange, Context, 0, SpellingListIndex); + SourceLocation AttrLoc = AttrRange.getBegin(); + + if (!isValidPointerAttrType(ResultType, /* RefOkay */ true)) { + Diag(AttrLoc, diag::warn_attribute_return_pointers_refs_only) + << &TmpAttr << AttrRange << SR; + return; + } + + int IndexVal; + if (!checkPositiveIntArgument(*this, Attr, ParamExpr, IndexVal, /*Index=*/1)) + return; + + const auto *FuncDecl = cast(D); + if (!checkParamIsIntegerType(*this, FuncDecl, Attr, IndexVal, + /*AttrArgNo=*/0)) + return; + + D->addAttr(::new (Context) AllocAlignAttr(AttrRange, Context, IndexVal, + SpellingListIndex)); +} + /// Normalize the attribute, __foo__ becomes foo. /// Returns true if normalization was applied. static bool normalizeName(StringRef &AttrName) { @@ -5837,6 +5872,9 @@ case AttributeList::AT_AssumeAligned: handleAssumeAlignedAttr(S, D, Attr); break; + case AttributeList::AT_AllocAlign: + handleAllocAlignAttr(S, D, Attr); + break; case AttributeList::AT_Overloadable: handleSimpleAttribute(S, D, Attr); break; Index: test/CodeGen/alloc-align-attr.c =================================================================== --- test/CodeGen/alloc-align-attr.c +++ test/CodeGen/alloc-align-attr.c @@ -0,0 +1,61 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -emit-llvm -o - %s | FileCheck %s + +__INT32_TYPE__*m1(__INT32_TYPE__ i) __attribute__((alloc_align(1))); + +// Condition where parameter to m1 is not size_t. +__INT32_TYPE__ test1(__INT32_TYPE__ a) { +// CHECK: define i32 @test1 + return *m1(a); +// CHECK: call i32* @m1(i32 [[PARAM1:%[^\)]+]]) +// CHECK: [[ALIGNCAST1:%.+]] = zext i32 [[PARAM1]] to i64 +// CHECK: [[ISPOS1:%.+]] = icmp ugt i64 [[ALIGNCAST1]], 0 +// CHECK: [[POSMASK1:%.+]] = sub i64 [[ALIGNCAST1]], 1 +// CHECK: [[MASK1:%.+]] = select i1 [[ISPOS1]], i64 [[POSMASK1]], i64 0 +// CHECK: [[PTRINT1:%.+]] = ptrtoint +// CHECK: [[MASKEDPTR1:%.+]] = and i64 [[PTRINT1]], [[MASK1]] +// CHECK: [[MASKCOND1:%.+]] = icmp eq i64 [[MASKEDPTR1]], 0 +// CHECK: call void @llvm.assume(i1 [[MASKCOND1]]) +} +// Condition where test2 param needs casting. +__INT32_TYPE__ test2(__SIZE_TYPE__ a) { +// CHECK: define i32 @test2 + return *m1(a); +// CHECK: call i32* @m1(i32 [[PARAM2:%[^\)]+]]) +// CHECK: [[ALIGNCAST2:%.+]] = zext i32 [[PARAM2]] to i64 +// CHECK: [[ISPOS2:%.+]] = icmp ugt i64 [[ALIGNCAST2]], 0 +// CHECK: [[POSMASK2:%.+]] = sub i64 [[ALIGNCAST2]], 1 +// CHECK: [[MASK2:%.+]] = select i1 [[ISPOS2]], i64 [[POSMASK2]], i64 0 +// CHECK: [[PTRINT2:%.+]] = ptrtoint +// CHECK: [[MASKEDPTR2:%.+]] = and i64 [[PTRINT2]], [[MASK2]] +// CHECK: [[MASKCOND2:%.+]] = icmp eq i64 [[MASKEDPTR2]], 0 +// CHECK: call void @llvm.assume(i1 [[MASKCOND2]]) +} +__INT32_TYPE__ *m2(__SIZE_TYPE__ i) __attribute__((alloc_align(1))); + +// test3 param needs casting, but 'm2' is correct. +__INT32_TYPE__ test3(__INT32_TYPE__ a) { +// CHECK: define i32 @test3 + return *m2(a); +// CHECK: call i32* @m2(i64 [[PARAM3:%[^\)]+]]) +// CHECK: [[ISPOS3:%.+]] = icmp ugt i64 [[PARAM3]], 0 +// CHECK: [[POSMASK3:%.+]] = sub i64 [[PARAM3]], 1 +// CHECK: [[MASK3:%.+]] = select i1 [[ISPOS3]], i64 [[POSMASK3]], i64 0 +// CHECK: [[PTRINT3:%.+]] = ptrtoint +// CHECK: [[MASKEDPTR3:%.+]] = and i64 [[PTRINT3]], [[MASK3]] +// CHECK: [[MASKCOND3:%.+]] = icmp eq i64 [[MASKEDPTR3]], 0 +// CHECK: call void @llvm.assume(i1 [[MASKCOND3]]) +} + +// Every type matches, canonical example. +__INT32_TYPE__ test4(__SIZE_TYPE__ a) { +// CHECK: define i32 @test4 + return *m2(a); +// CHECK: call i32* @m2(i64 [[PARAM4:%[^\)]+]]) +// CHECK: [[ISPOS4:%.+]] = icmp ugt i64 [[PARAM4]], 0 +// CHECK: [[POSMASK4:%.+]] = sub i64 [[PARAM4]], 1 +// CHECK: [[MASK4:%.+]] = select i1 [[ISPOS4]], i64 [[POSMASK4]], i64 0 +// CHECK: [[PTRINT4:%.+]] = ptrtoint +// CHECK: [[MASKEDPTR4:%.+]] = and i64 [[PTRINT4]], [[MASK4]] +// CHECK: [[MASKCOND4:%.+]] = icmp eq i64 [[MASKEDPTR4]], 0 +// CHECK: call void @llvm.assume(i1 [[MASKCOND4]]) +} Index: test/Sema/alloc-align-attr.c =================================================================== --- test/Sema/alloc-align-attr.c +++ test/Sema/alloc-align-attr.c @@ -0,0 +1,22 @@ +// RUN: %clang_cc1 -fsyntax-only -verify %s + +// return values +void test_void_alloc_align(void) __attribute__((alloc_align(1))); // expected-warning {{'alloc_align' attribute only applies to return values that are pointers}} +int test_int_alloc_align(void) __attribute__((alloc_align(1))); // expected-warning {{'alloc_align' attribute only applies to return values that are pointers}} +void *test_ptr_alloc_align(int a) __attribute__((alloc_align(1))); // no-warning + +int j __attribute__((alloc_align(1))); // expected-warning {{'alloc_align' attribute only applies to functions}} +void *test_no_params_zero() __attribute__((alloc_align(0))); // expected-error {{'alloc_align' attribute parameter 0 is out of bounds}} +void *test_no_params() __attribute__((alloc_align(1))); // expected-error {{'alloc_align' attribute parameter 1 is out of bounds}} +void *test_insufficient_params(int a) __attribute__((alloc_align(2))); // expected-error {{'alloc_align' attribute parameter 2 is out of bounds}} +void *test_incorrect_param_type(float a) __attribute__((alloc_align(1))); // expected-error {{'alloc_align' attribute argument may only refer to a function parameter of integer type}} + +// argument type +void *test_bad_param_type(void) __attribute((alloc_align(1.1))); // expected-error {{'alloc_align' attribute requires parameter 1 to be an integer constant}} +void *test_bad_param_type(void) __attribute((alloc_align("Foo"))); // expected-error {{'alloc_align' attribute requires parameter 1 to be an integer constant}} + +// argument count +void *test_no_fn_proto() __attribute__((alloc_align)); // expected-error {{'alloc_align' attribute takes one argument}} +void *test_no_fn_proto() __attribute__((alloc_align())); // expected-error {{'alloc_align' attribute takes one argument}} +void *test_no_fn_proto() __attribute__((alloc_align(32, 45, 37))); // expected-error {{'alloc_align' attribute takes one argument}} +