Index: lib/Fuzzer/test/CMakeLists.txt =================================================================== --- lib/Fuzzer/test/CMakeLists.txt +++ lib/Fuzzer/test/CMakeLists.txt @@ -39,6 +39,8 @@ set(CMAKE_CXX_CREATE_SHARED_LIBRARY " ${CMAKE_CXX_FLAGS} ${CRT_FLAG} /LD -o /link ") endif() +add_custom_target(TestBinaries) + # add_libfuzzer_test( # SOURCES source0.cpp [source1.cpp ...] # ) @@ -63,12 +65,9 @@ PROPERTIES RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/lib/Fuzzer/test" ) - set(TestBinaries ${TestBinaries} LLVMFuzzer-${name} PARENT_SCOPE) + add_dependencies(TestBinaries LLVMFuzzer-${name}) endfunction() -# Variable to keep track of all test targets -set(TestBinaries) - ############################################################################### # Basic tests ############################################################################### @@ -166,13 +165,13 @@ "${LLVM_MAIN_SRC_DIR}/utils/unittest/googletest/include" ) -set(TestBinaries ${TestBinaries} LLVMFuzzer-Unittest) +add_dependencies(TestBinaries LLVMFuzzer-Unittest) set_target_properties(LLVMFuzzer-Unittest PROPERTIES RUNTIME_OUTPUT_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}" ) -set(TestBinaries ${TestBinaries} LLVMFuzzer-StandaloneInitializeTest) +add_dependencies(TestBinaries LLVMFuzzer-StandaloneInitializeTest) set_target_properties(LLVMFuzzer-StandaloneInitializeTest PROPERTIES RUNTIME_OUTPUT_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}" @@ -218,7 +217,7 @@ LIBRARY_DIR "${CMAKE_BINARY_DIR}/lib/Fuzzer/lib") endif() -set(TestBinaries ${TestBinaries} LLVMFuzzer-DSOTest) +add_dependencies(TestBinaries LLVMFuzzer-DSOTest) ############################################################################### # Configure lit to run the tests @@ -243,7 +242,7 @@ add_lit_testsuite(check-fuzzer "Running Fuzzer tests" ${CMAKE_CURRENT_BINARY_DIR} - DEPENDS ${TestBinaries} + DEPENDS TestBinaries ) # Don't add dependencies on Windows. The linker step would fail on Windows, Index: lib/Fuzzer/test/no-coverage/CMakeLists.txt =================================================================== --- lib/Fuzzer/test/no-coverage/CMakeLists.txt +++ lib/Fuzzer/test/no-coverage/CMakeLists.txt @@ -25,6 +25,5 @@ "${CMAKE_BINARY_DIR}/lib/Fuzzer/test" ) - # Propagate value into parent directory - set(TestBinaries ${TestBinaries} AFLDriverTest PARENT_SCOPE) + add_dependencies(TestBinaries AFLDriverTest) endif() Index: lib/Fuzzer/test/ubsan/CMakeLists.txt =================================================================== --- lib/Fuzzer/test/ubsan/CMakeLists.txt +++ lib/Fuzzer/test/ubsan/CMakeLists.txt @@ -10,6 +10,3 @@ foreach(Test ${UbsanTests}) add_libfuzzer_test(${Test}-Ubsan SOURCES ../${Test}.cpp) endforeach() - -# Propagate value into parent directory -set(TestBinaries ${TestBinaries} PARENT_SCOPE) Index: lib/Fuzzer/test/uninstrumented/CMakeLists.txt =================================================================== --- lib/Fuzzer/test/uninstrumented/CMakeLists.txt +++ lib/Fuzzer/test/uninstrumented/CMakeLists.txt @@ -11,6 +11,3 @@ foreach(Test ${UninstrumentedTests}) add_libfuzzer_test(${Test}-Uninstrumented SOURCES ../${Test}.cpp) endforeach() - -# Propagate value into parent directory -set(TestBinaries ${TestBinaries} PARENT_SCOPE)